search

rodentrabies / bp

Bitcoin Protocol components in Common Lisp
MIT License
37 stars 8 forks source link

crypto: fix expected argument type in `serialize-pubkey` #11

Closed Titan-C closed 1 year ago

Titan-C commented 1 year ago

To serialize a pubkey the function needs the pubkey-bytes, the function as written now took a private key. This fixes the function to request the correct struct of a pubkey by using the correct slot reader.

Additionally include the compressed key argument.

rodentrabies commented 1 year ago

Sorry for the delay in review of this as well as #12 and #13. For some reason, my notification settings were wrong and I didn't get notified on new PRs. I'll get to reviewing these today.

Meanwhile, please use the following convention for commit messages (here and in #12 and #13)

<component>: <description>

and also please use "`" markers for references to Lisp symbols in commit messages. For example, for this commit, it should be something like

crypto: fix expected argument type in `serialize-pubkey`

PS: thanks a lot for your contributions, I greatly appreciate your interest in this tiny project :smile: