rodgomesc / vision-camera-code-scanner

VisionCamera Frame Processor Plugin to read barcodes using MLKit Vision QrCode Scanning
MIT License
336 stars 222 forks source link

Port to react-native-vision-camera v3 #155

Open jacargentina opened 1 year ago

jacargentina commented 1 year ago

Any work on this migration has been started?

riamon-v commented 1 year ago

Yeah, really looking forward to it !

DeveloperMCD commented 1 year ago

rodgomesc / vision-camera-code-scanner is 100% dead. Deprecated. No longer maintained. There's no other way to say it. Yes, it's only been 1.5 years since the last commit, but in 5 years it will be 6.5 years. And it WILL get to that point.

Every abandoned, dead Git repo with "no commits for 7 years" looked like this one at the 1.5 year mark.

But the port -- the successor -- you speak of is MOSTLY done. But it has a few issues. The work was done by MacKinnon in this fork: https://github.com/rkmackinnon/vision-camera-code-scanner/tree/react-native-vision-camera-v3

And released to NPM via this copy of MacKinnon's fork: https://www.npmjs.com/package/vision-camera-v3-barcode-scanner

fengye1 commented 1 year ago

@DeveloperMCD I encountered an error, does this support reactnative 0.72 version, or can I fix it?

image

"react-native": "0.72.3", "react-native-vision-camera": "3.0.0-rc.5", "react-native-worklets-core": "^0.2.0", "vision-camera-v3-barcode-scanner": "^1.0.2"

DeveloperMCD commented 1 year ago

You should be using the latest RNVC release candidate, just for starters. Currently on RC8. RC6 had some major changes; it's what allowed me to successfully build my App again!

But that's not going to fix the Barcode Scanner. That library has more fixes that need to be done to it to make it work with RNVC version 3. No one has worked on that fork in the past 5 months, unfortunately. And I've never worked on it personally. So I'm not the man for the job.

Also, why not use RN 0.72.4? I haven't heard a single reason why to use 0.72.2 or .3 but not .4

khanakia commented 1 year ago

I am using this ported version 3 https://github.com/rkmackinnon/vision-camera-code-scanner and getting below error The method does not override any method from its superclass Screenshot 2023-08-30 at 11 01 26 PM

ikimiler commented 1 year ago

您应该使用最新的 RNVC 候选版本,仅适用于初学者。目前在RC8上。 RC6有一些重大变化;这就是让我再次成功构建我的应用程序的原因!

但这不会修复条形码扫描仪。该库需要对其进行更多修复,以使其与 RNVC 版本 3 一起使用。不幸的是,在过去的 5 个月里,没有人在那个分叉上工作过。而且我个人从来没有做过这件事。所以我不是这份工作的人。

另外,为什么不使用RN 0.72.4?我还没有听到为什么使用 0.72.2 或 .3 而不是 .4 的原因

image

image

have a code error,,,,,

lBroth commented 1 year ago

I am using this ported version 3 https://github.com/rkmackinnon/vision-camera-code-scanner and getting below error The method does not override any method from its superclass Screenshot 2023-08-30 at 11 01 26 PM

same error

niStee commented 1 year ago

But the port -- the successor -- you speak of is MOSTLY done. But it has a few issues. The work was done by MacKinnon in this fork: https://github.com/rkmackinnon/vision-camera-code-scanner/tree/react-native-vision-camera-v3

And released to NPM via this copy of MacKinnon's fork: https://www.npmjs.com/package/vision-camera-v3-barcode-scanner

Doesn't work out of the box does it?

minhna commented 1 year ago

https://github.com/mrousavy/react-native-vision-camera/pull/1912

mgcrea commented 1 year ago

I've just released a frame processor rebuilt for vision-camera 3+ that can do high (configurable) fps scanning and provides highlighting of detected barcodes out-of-the-box. Uses MLKit on Android and Apple Vision on iOS.

You can check a working demo on GitHub @mgcrea/vision-camera-barcode-scanner.

Hope it helps.