rodgomesc / vision-camera-face-detector

VisionCamera Frame Processor Plugin to detect faces using MLKit Vision Face Detector
MIT License
94 stars 66 forks source link

`scanFaces` in worklet crashes app #27

Open mxmzb opened 2 years ago

mxmzb commented 2 years ago

i'm getting this - any idea how to debug this best (or maybe it's a library bug)?

CleanShot 2022-07-31 at 17 28 13@2x

fresh app, these are my deps:

{
"dependencies": {
    "react": "18.2.0",
    "react-native": "0.69.3",
    "react-native-reanimated": "^2.9.1",
    "react-native-vision-camera": "^2.14.0",
    "vision-camera-face-detector": "^0.1.8",
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/runtime": "^7.12.5",
    "babel-jest": "^28.1.3",
    "babel-plugin-module-resolver": "^4.1.0",
    "concurrently": "^7.3.0",
    "metro-react-native-babel-preset": "^0.72.0",
    "react-test-renderer": "18.2.0",
  }
}

my code:

import React from "react";
import { StyleSheet } from "react-native";
import { Camera, useCameraDevices, useFrameProcessor } from "react-native-vision-camera";
import { runOnJS } from "react-native-reanimated";

import { Ratio } from "@happycam/shared/atomic-components";

import { scanFaces, Face } from "vision-camera-face-detector";

const StreamCapture = React.memo(() => {
  const devices = useCameraDevices();
  const [cameraDevice, setCameraDevice] = React.useState("front");
  const [hasVideoPermission, setHasVideoPermissions] = React.useState(false);
  const [faces, setFaces] = React.useState<Face[]>();

  React.useEffect(() => {
    const requestCameraPermission = async () => {
      const cameraPermission = await Camera.getCameraPermissionStatus();

      if (cameraPermission !== "authorized") {
        const newCameraPermission = await Camera.requestCameraPermission();

        if (newCameraPermission === "authorized") {
          setHasVideoPermissions(true);
        }
      } else {
        setHasVideoPermissions(true);
      }
    };

    requestCameraPermission();
  }, []);

  const frameProcessor = useFrameProcessor(frame => {
    "worklet";

    const scannedFaces = scanFaces(frame);
    runOnJS(setFaces)(scannedFaces);
  }, []);

  const device = cameraDevice === "front" ? devices.front : devices.back;

  if (device !== null && hasVideoPermission) {
    return (
      <Ratio ratio={4 / 3}>
        <Camera
          style={StyleSheet.absoluteFill}
          device={device}
          isActive={true}
          video={true}
          audio={false}
          frameProcessor={frameProcessor}
          frameProcessorFps={5}
        />
      </Ratio>
    );
  }

  // TODO show message that there is no device
  return null;
});

export default StreamCapture;
Rikirhenaldi commented 2 years ago

@mxmzb Have you found a way to solve this problem ? I'm having the same issue.

eloisasmorais commented 2 years ago

I was able to fix this by adding the following lines to babel.config.js

plugins: [
    [
      'react-native-reanimated/plugin',
      {
        globals: ['__scanFaces'],
      },
    ],
  ],

restart metro-bundler, if it doesn't work run yarn start --reset-cache

mxmzb commented 2 years ago

@Rikirhenaldi no, sorry

I was able to fix this by adding the following lines to babel.config.js

plugins: [
    [
      'react-native-reanimated/plugin',
      {
        globals: ['__scanFaces'],
      },
    ],
  ],

restart metro-bundler, if it doesn't work run yarn start --reset-cache

doesn't work for me

adamdavareln commented 1 year ago

@Rikirhenaldi no, sorry

I was able to fix this by adding the following lines to babel.config.js

plugins: [
    [
      'react-native-reanimated/plugin',
      {
        globals: ['__scanFaces'],
      },
    ],
  ],

restart metro-bundler, if it doesn't work run yarn start --reset-cache

doesn't work for me

same for me

mat2718 commented 1 year ago

can you try adding setFaces to the array in your frame processor and see if that works