Implement bounding box calculation on iOS

rodgomesc / vision-camera-face-detector

VisionCamera Frame Processor Plugin to detect faces using MLKit Vision Face Detector

MIT License

89 stars 65 forks source link

Implement bounding box calculation on iOS #9

Closed didithilmy closed 2 years ago

didithilmy commented 2 years ago

bounds attribute on Face always returns empty object on iOS, this PR fixes it. Fix #3

Mohamed-kassim commented 2 years ago

@rodgomesc any update about merging this?

rodgomesc commented 2 years ago

hey, sorry for the delayed feedback, i’ll try to test this that week and release a new version

genaris commented 2 years ago

Nice to see this PR! I've tested it with the front camera of a 1st-gen iPhone SE and worked flawlessly.

Seems to be working exactly as in Android, with the exception of x coordinates, that are not mirrored as found in #10. IMO this is the correct behaviour.

thanhchuongbmd commented 2 years ago

Please update latest version on npm!