search

rodhoward / node-sybase

23 stars 55 forks source link

Consistently use double quotes for strings #18

Open theneva opened 6 years ago

rodhoward commented 6 years ago

Hi Martin,

Thanks for you're input all your suggestions seem really good! I hesitate to make changes though because I don't have access to Sybase so I can't test anything. This was a little internal, non production ready, lib that I used for a few dashboards and testing lobbies at my last job. Please fork it if you think its worth the effort.

For me the main problem is communicating over the command line to java, there has got to be a better way to integrate java into javascript. If not then the messaging layer could be a lot more complete with better error messages and error handling.

Regards Rod

On 29 September 2017 at 16:23, Martin Lehmann notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/rodhoward/node-sybase/pull/18 Commit Summary

  • incrementing the version number.
  • Consistently use double quotes for strings

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rodhoward/node-sybase/pull/18, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_kCfYkTz4u4fM0DB_w4MkT24rJASOtks5snIzsgaJpZM4PoPs2 .

theneva commented 6 years ago

Hey!

I see. I think a better route might be to adapt an existing jTDS implementation for Node instead of triggering a Java app—I'll have to think about it.

Is there any way you'd be willing to merge https://github.com/rodhoward/node-sybase/pull/15? It's a pretty obvious tiny change.