search

rodhoward / node-sybase

23 stars 55 forks source link

Does this library need to support Node < 6? #20

Closed theneva closed 3 years ago

theneva commented 6 years ago

Node 6 has been in LTS since October last year, and Node 8 is scheduled to enter LTS in October.

This library makes heavy use of things like function which requires things like var this = that; (compare with arrow functions), and var which has been replaced with const and let.

I'd be happy to send a PR with what an "upgrade" to Node 6 would look like if upgrading is a possibility.

rodhoward commented 3 years ago

yeah its like going back in a time machine! I think we leave it as is because the test cases aren't great and we can't test it ourselves.