search

rodhoward / node-sybase

23 stars 55 forks source link

Consistent Column count with null values across resultset #26

Open gkarthiks opened 6 years ago

gkarthiks commented 6 years ago

Issue Reference: #25

Description:

The previous version was ignoring the columns having null values for any records at any position.

So for example, if the first row has null for column number 2, then that column will not be added. If the next row has null for 3rd column and that will not be added in the JSON resulting in inconsistent column counts across the result set JSON.

  1. Adding the attribute allowNull as an optional parameter to include null valued columns in the response JSON for maintaining the consistent column count across rows. If not passed, then the driver will work as earlier. No need to change anything, already backward compatible.
  2. Added the auto created JavaDoc files.

TODOs:

theneva commented 4 years ago

Hi! This repo is no longer maintained (nobody here has access to a Sybase instance to test it anymore), so I'm afraid this is pretty unlikely to get merged.

cezarcatarin commented 3 years ago

Oi! Este repo não é mais mantido (ninguém aqui tem acesso a uma instância do Sybase para testá-lo), então temo que seja muito improvável que seja mesclado.

I'm having this same problem, can anyone accept the pull request? can i help to test

lroal commented 3 years ago

I am having the same problem. This is a big show stopper.

gkarthiks commented 2 years ago

If anyone is ready to accept this, I can rebase and resolve conflicts.