rodi01 / RenameIt

Keep your Sketch files organized, batch rename layers and artboards.
https://renameit.design/sketch/
MIT License
1.41k stars 111 forks source link

Modal not showing up #121

Closed rock-san closed 5 years ago

rock-san commented 5 years ago

Hi! Thanks for making this plugin, I use it almost every day. I've been having this issue over the last few days that when I try to select 'Find and Replace Layers/Artboards Names' from the plugins menu (or I type in the shortcut) no modal comes up. I was wondering if anyone else was having this issue?

I'm using version 4.1.4 of Rename-It and version 54.1 of Sketch

rodi01 commented 5 years ago

@rock-san have you tried restarting sketch?

rock-san commented 5 years ago

Hi @rodi01, I've restarted Sketch (and Abstract since I've been opening up the Sketch files from Abstract) and still no dice. The other two items in the Rename It menu are still working though.

rodi01 commented 5 years ago

Do you see an empty window or nothing at all?

rodi01 commented 5 years ago

Can you remove the plugin all together, restart sketch and install this version: https://github.com/rodi01/RenameIt/releases/download/v4.2.0-BETA/Rename-It.sketchplugin.zip

rock-san commented 5 years ago

Nothing comes up when I click on it. I've uninstalled it and installed the version you've linked to and restarted but nothing comes up still. I've installed and older version of Rename It from someone else in my team (version 2.03) and have it working now.

rock-san commented 5 years ago

I'm happy to replicate this issue again if you want to investigate it further. Hopefully it was just me experiencing it. Thanks again Rodi for helping me troubleshoot it though.

rodi01 commented 5 years ago

Do you know if version 4.0 was working for you? When you have some time, could you give it a try: https://github.com/rodi01/RenameIt/releases/download/v4.0.0/Rename-It.sketchplugin.zip

nandorocker commented 5 years ago

+1 here Started after I updated sketch today.

Ah, 4.0 does work.

rodi01 commented 5 years ago

Could one of you try to see if there is any error on the console for the latest release?

rodi01 commented 5 years ago

@nandorocker @rock-san I think I found the issue... Could you guys try the latest version, 4.1.5?

Make sure you restart sketch

krdesign commented 5 years ago

This is my issue with sketch 55 version.

Screenshot 2019-05-22 at 09 59 04

My log

TypeError: null is not an object (evaluating 'u.symbolMaster().name') at i (/Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It.sketchplugin/Contents/Sketch/commandFindReplace.js:1:57273) at r (/Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It.sketchplugin/Contents/Sketch/commandFindReplace.js:1:57521) at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It.sketchplugin/Contents/Sketch/commandFindReplace.js:1:58131 at forEach[native code] (/) at o (/Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It.sketchplugin/Contents/Sketch/commandFindReplace.js:1:58100) at default (/Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It.sketchplugin/Contents/Sketch/commandFindReplace.js:1:62801) at __skpm_run (/Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It.sketchplugin/Contents/Sketch/commandFindReplace.js:1:62978) at __skpm_run[native code] (/)

rodi01 commented 5 years ago

@krdesign does that happen on the 4.1.5 version?

krdesign commented 5 years ago

@rodi01 Yes, I can confirm.

Screenshot 2019-05-22 at 17 35 03
krdesign commented 5 years ago

Maybe i think the problem is of mini modal of plugin if i click over the modal and dont do nothing the plugin window does not close but the "z-index" are over sketch if i minimize sketch, i will try to show with a short video.

Screen Recording 2019-05-22 at 17.52.12.mov.zip

rodi01 commented 5 years ago

@krdesign I see... I just pushed a version that tries to keep the window on top all the time and I added extra check for the error that you were seeing. Could you please give it a shot?

I think you will need to restart Sketch after updating it

krdesign commented 5 years ago

@rodi01 Thank you!

nandorocker commented 5 years ago

Works for me :)

rodi01 commented 5 years ago

Thanks you all for the help. I’m going to close this issue. @rock-san try the latest version, it should be working now.