rodi01 / RenameIt

Keep your Sketch files organized, batch rename layers and artboards.
https://renameit.design/sketch/
MIT License
1.41k stars 110 forks source link

"Find & Replace layer names" opens blank window #68

Closed kium-one closed 5 years ago

kium-one commented 6 years ago

When I select artboards and choose the Find & Replace option, it takes a while to open, and I then see a blank window. Version 3.7.0. Tried reinstalling as well, no lock. Works well on my other Macbook, but not on this one. They both have High Sierra and the same Sketch version.

screen shot 2018-01-31 at 10 41 20 am
rodi01 commented 6 years ago

@najiglass Sorry about that 😞 Could you take a look on the console for any error? I've never seen this before. /Applications/Utilities/Console.app

it should be under report

screen shot 2018-01-31 at 10 50 14 am

cameronhenkes commented 6 years ago

Same error for me...

Reporting: "No WebView present. Event cannot be posted to the web UI. «Plugin Output»" in Console, Output...

Currently using Sketch 48.2

rodi01 commented 6 years ago

@chenkes I will take a look.

kium-one commented 6 years ago

I get all of this if I filter on "Sketch", at the moment I open the Find & Replace.

default 16:23:11.984200 -0800 Sketch Task <2F1A61DF-DAF1-4F94-8C60-D092D0ED4ADA>.<941> now using Connection 271 default 16:23:11.984327 -0800 Sketch Task <2F1A61DF-DAF1-4F94-8C60-D092D0ED4ADA>.<941> sent request, body N default 16:23:11.984934 -0800 Sketch Task <2F1A61DF-DAF1-4F94-8C60-D092D0ED4ADA>.<941> received response, status 200 content K default 16:23:11.985088 -0800 Sketch Task <2F1A61DF-DAF1-4F94-8C60-D092D0ED4ADA>.<941> response ended default 16:23:22.904390 -0800 Sketch 0x194858000 - DocumentLoader::startLoadingMainResource: Returning empty document (frame = 0x155d95c30, main = 1) default 16:23:22.904466 -0800 Sketch Memory usage info dump at MainFrameLoadCompleted: default 16:23:22.904488 -0800 Sketch phys_footprint: 2044530688 default 16:23:22.904524 -0800 Sketch virtual_size: 9982926848 default 16:23:22.904540 -0800 Sketch resident_size: 2341515264 default 16:23:22.904555 -0800 Sketch internal: 2263904256 default 16:23:22.904571 -0800 Sketch compressed: 162164736 default 16:23:22.904586 -0800 Sketch pagecache_page_count: 0 default 16:23:22.904600 -0800 Sketch javascript_gc_heap_capacity: 52286904 default 16:23:22.904615 -0800 Sketch document_count: 25 default 16:23:22.904630 -0800 Sketch javascript_gc_heap_extra_memory_size: 11539592 default 16:23:22.906639 -0800 Sketch Memory usage info dump at MainFrameLoadStarted: default 16:23:22.906697 -0800 Sketch phys_footprint: 2044571648 default 16:23:22.906717 -0800 Sketch virtual_size: 9982926848 default 16:23:22.906733 -0800 Sketch resident_size: 2341556224 default 16:23:22.906748 -0800 Sketch internal: 2263945216 default 16:23:22.906762 -0800 Sketch compressed: 162164736 default 16:23:22.906787 -0800 Sketch pagecache_page_count: 0 default 16:23:22.906810 -0800 Sketch javascript_gc_heap_capacity: 52286904 default 16:23:22.906833 -0800 Sketch document_count: 25 default 16:23:22.906941 -0800 Sketch javascript_gc_heap_extra_memory_size: 11539592 default 16:23:22.907197 -0800 Sketch 0x7fba9d5f4ef0 - FrameLoader::prepareForLoadStart: Starting frame load (frame = 0x155d95c30, main = 1) default 16:23:22.907262 -0800 Sketch 0x194851000 - DocumentLoader::startLoadingMainResource: Starting load (frame = 0x155d95c30, main = 1) default 16:23:23.425779 -0800 Sketch *** WebKit discarded an uncaught exception in the webView:didChangeLocationWithinPageForFrame: delegate: TypeError: undefined is not an object (evaluating '(C=r(C)).pluginAction') default 16:23:23.437815 -0800 Sketch Memory usage info dump at MainFrameLoadCompleted: default 16:23:23.437863 -0800 Sketch phys_footprint: 2227888128 default 16:23:23.437887 -0800 Sketch virtual_size: 9970855936 default 16:23:23.437905 -0800 Sketch resident_size: 2405498880 default 16:23:23.437923 -0800 Sketch internal: 2334191616 default 16:23:23.437939 -0800 Sketch compressed: 162164736 default 16:23:23.437956 -0800 Sketch pagecache_page_count: 0 default 16:23:23.437972 -0800 Sketch javascript_gc_heap_capacity: 54646056 default 16:23:23.438031 -0800 Sketch document_count: 25 default 16:23:23.438063 -0800 Sketch javascript_gc_heap_extra_memory_size: 11539592 default 16:23:23.438176 -0800 Sketch 0x7fba9d5f4ef0 - FrameLoader::checkLoadCompleteForThisFrame: Finished frame load (frame = 0x155d95c30, main = 1) default 16:23:23.444039 -0800 Sketch TIC TCP Conn Start [283:0x604000b66480] default 16:23:23.444164 -0800 Sketch Task <988188F1-CE84-4F99-964D-B635C9BB63FF>.<0> setting up Connection 283 default 16:23:23.444280 -0800 Sketch TIC TCP Conn Start [284:0x60400077cc80] default 16:23:23.444481 -0800 Sketch Task .<0> setting up Connection 284 default 16:23:23.444709 -0800 Sketch TIC TCP Conn Start [285:0x608000b720c0] default 16:23:23.444833 -0800 Sketch Task <468351AC-36AA-4E8B-94BE-D0F4D6A567AF>.<0> setting up Connection 285 default 16:23:23.490467 -0800 Sketch TIC TCP Conn Connected [283:0x604000b66480]: Err(16) default 16:23:23.490732 -0800 Sketch TIC TCP Conn Event [283:0x604000b66480]: 1 default 16:23:23.491248 -0800 Sketch Task <988188F1-CE84-4F99-964D-B635C9BB63FF>.<0> now using Connection 283 default 16:23:23.491442 -0800 Sketch Task <988188F1-CE84-4F99-964D-B635C9BB63FF>.<0> sent request, body N default 16:23:23.494192 -0800 Sketch TIC TCP Conn Connected [284:0x60400077cc80]: Err(16) default 16:23:23.494318 -0800 Sketch TIC TCP Conn Event [284:0x60400077cc80]: 1 default 16:23:23.494618 -0800 Sketch Task .<0> now using Connection 284 default 16:23:23.494734 -0800 Sketch Task .<0> sent request, body N default 16:23:23.500032 -0800 Sketch TIC TCP Conn Connected [285:0x608000b720c0]: Err(16) default 16:23:23.500151 -0800 Sketch TIC TCP Conn Event [285:0x608000b720c0]: 1 default 16:23:23.500415 -0800 Sketch Task <468351AC-36AA-4E8B-94BE-D0F4D6A567AF>.<0> now using Connection 285 default 16:23:23.500568 -0800 Sketch Task <468351AC-36AA-4E8B-94BE-D0F4D6A567AF>.<0> sent request, body N default 16:23:23.513340 -0800 Sketch Task .<0> received response, status 200 content K default 16:23:23.513498 -0800 Sketch Task .<0> response ended default 16:23:23.521183 -0800 Sketch Task <468351AC-36AA-4E8B-94BE-D0F4D6A567AF>.<0> received response, status 200 content K default 16:23:23.521327 -0800 Sketch Task <468351AC-36AA-4E8B-94BE-D0F4D6A567AF>.<0> response ended default 16:23:23.542391 -0800 Sketch Task .<942> now using Connection 271 default 16:23:23.542517 -0800 Sketch Task .<942> sent request, body N default 16:23:23.543492 -0800 Sketch Task .<942> received response, status 200 content K default 16:23:23.543622 -0800 Sketch Task .<942> response ended default 16:23:23.588293 -0800 Sketch Task <988188F1-CE84-4F99-964D-B635C9BB63FF>.<0> received response, status 200 content C default 16:23:23.588504 -0800 Sketch Task <988188F1-CE84-4F99-964D-B635C9BB63FF>.<0> response ended default 16:23:23.597456 -0800 Sketch Task .<0> now using Connection 283 default 16:23:23.597651 -0800 Sketch Task .<0> sent request, body N default 16:23:23.615415 -0800 Sketch Task .<0> received response, status 200 content K default 16:23:23.615613 -0800 Sketch Task .<0> response ended default 16:23:28.653607 -0800 Sketch TIC TCP Conn Event [282:0x60800096d5c0]: 3 error 16:23:28.653632 -0800 Sketch TIC TCP Conn Failed [282:0x60800096d5c0]: 3:-9802 Err(-9802) default 16:23:28.653652 -0800 Sketch TIC TCP Conn Cancel [282:0x60800096d5c0] default 16:23:28.653735 -0800 Sketch NSURLSession/NSURLConnection HTTP load failed (kCFStreamErrorDomainSSL, -9802) error 16:23:28.653795 -0800 Sketch Task <404CA863-7875-4FE5-BC78-E32513139518>.<0> HTTP load failed (error code: -1200 [3:-9802]) default 16:23:28.655586 -0800 Sketch TIC TCP Conn Destroyed [282:0x60800096d5c0] default 16:23:28.655739 -0800 Sketch TIC Enabling TLS [286:0x604000b7ad00] default 16:23:28.655773 -0800 Sketch TIC TCP Conn Start [286:0x604000b7ad00] default 16:23:28.655899 -0800 Sketch Task <737395CD-99EA-4ADD-85FC-C582C7B63046>.<0> setting up Connection 286 default 16:23:28.815030 -0800 Sketch TIC TLS Event [286:0x604000b7ad00]: 1, Pending(0) default 16:23:28.913343 -0800 Sketch TIC TLS Event [286:0x604000b7ad00]: 2, Pending(0) default 16:23:28.914011 -0800 Sketch TIC TLS Event [286:0x604000b7ad00]: 11, Pending(0) default 16:23:28.914723 -0800 Sketch TIC TLS Event [286:0x604000b7ad00]: 12, Pending(0) default 16:23:28.914791 -0800 Sketch TIC TLS Event [286:0x604000b7ad00]: 14, Pending(0)

rodi01 commented 6 years ago

Thanks @najiglass. I'll take a look on it this weekend.

kium-one commented 6 years ago

@rodi01 Any updates? Any alternatives that you know of in the meantime? Thanks!

rodi01 commented 6 years ago

@najiglass Can you try the latest update? I've changed a couple of things but I don't think it has fixed your issue. It's hard to fix it since I can't reproduce it on my end, I'm trying to get help on this from other plugin developers. Sorry for the delay.

kium-one commented 6 years ago

Thanks! Unfortunately no, still doesn’t work with the new update.

rodi01 commented 6 years ago

@najiglass if I send you a debug version of the plugin could you take a screenshot of the inspector and send it to me?

Sorry for the hassle but I can’t find a way to reproduce it.

kium-one commented 6 years ago

Yes for sure!

Andrey

On Feb 27, 2018, at 8:52 PM, Rodrigo Soares notifications@github.com wrote:

@najiglass if I send you a debug version of the plugin could you take a screenshot of the inspector and send it to me?

Sorry for the hassle but I can’t find a way to reproduce it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rodi01 commented 6 years ago

Sorry for the delay @najiglass, it's been a busy week.

Here is the debug version: https://cl.ly/pwZZ Could you please download and install the plugin?

Once you've done that, run the find and replace command, you will see the empty screen.

Right click anywhere on the screen and you should see a menu:

inspect

Click on inspect Element and you should see this:

screen shot 2018-03-04 at 1 48 28 pm

Switch to the console tab:

screen shot 2018-03-04 at 1 48 48 pm

Can you screenshot that and send it to me? Hopefully I can see the error there.

Thanks again for your patience.

kium-one commented 6 years ago

Thanks! Unfortunately Chrome won't let me download that file, it's blocked as being dangerous.

Would you know why?

On Sun, Mar 4, 2018 at 2:07 PM, Rodrigo Soares notifications@github.com wrote:

Sorry for the delay @najiglass https://github.com/najiglass, it's been a busy week.

Here is the debug version: https://cl.ly/pwZZ Could you please download and install the plugin?

Once you've done that, run the find and replace command, you will see the empty screen.

Right click anywhere on the screen and you should see a menu: [image: inspect] https://user-images.githubusercontent.com/52461/36951125-97192b02-1fb4-11e8-9a10-12d2bd34ad10.png

Click on inspect Element and you should see this: [image: screen shot 2018-03-04 at 1 48 28 pm] https://user-images.githubusercontent.com/52461/36951150-ecbb4130-1fb4-11e8-9d19-b43d81058043.png

Switch to the console tab: [image: screen shot 2018-03-04 at 1 48 48 pm] https://user-images.githubusercontent.com/52461/36951154-109c7e16-1fb5-11e8-8b46-d7df6fab0302.png

Can you screenshot that and send it to me? Hopefully I can see the error there.

Thanks again for your patience.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rodi01/RenameIt/issues/68#issuecomment-370268687, or mute the thread https://github.com/notifications/unsubscribe-auth/AL_cEu2xEgdobhcb8uiNZ3thmuv79Ns7ks5tbGWNgaJpZM4R0dQh .

rodi01 commented 6 years ago

@najiglass this is so strange. I wonder if chrome doesn't like cloud app links. I re-uploaded it to dropbox here is the link: https://www.dropbox.com/s/rufuigtvaj7gzwn/Rename-It.sketchplugin.zip?dl=0

giuseppebergman commented 6 years ago

Hey, Same bug here, with Sketch 48.2 and plugin v3.7.2. Here's the screenshot (in two pieces) made with your debug version as suggested to najiglass: capture d ecran 2018-03-07 a 19h52 45

capture d ecran 2018-03-07 a 19h53 42

Thanks,

Giu_

rodi01 commented 6 years ago

Thanks @giuseppebergman! This is really helpful.

When you launch the find and replace, did you hav any later selected?

giuseppebergman commented 6 years ago

Sure, I've tried first with more than a dozen layers selected, then just three (when I captured the log), for the same result. I should add that there's an idle delay (several seconds) before the blank window displays.

Le 7 mars 2018 à 21h32, Rodrigo Soares notifications@github.com a écrit :

Thanks @giuseppebergman https://github.com/giuseppebergman! This is really helpful.

When you launch the find and replace, did you hav any later selected?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rodi01/RenameIt/issues/68#issuecomment-371274845, or mute the thread https://github.com/notifications/unsubscribe-auth/ALbXv1o_Omyr2hs0c_w6FwZ8E5CnLtb3ks5tcEPjgaJpZM4R0dQh.

rodi01 commented 6 years ago

@giuseppebergman can you try this build? https://www.dropbox.com/s/x8f9i4xo9kgqxds/Rename-It-find-rename.sketchplugin.zip?dl=0

If it doesn't work, can you do the same and send me the screenshot of the console.

Thanks! Apologies for the back and forth 😔

giuseppebergman commented 6 years ago

Here it is, no problem. Thank you for looking into it! The bug's still there, though there are less lines in the console, so I guess it's a progress :)

capture d ecran 2018-03-12 a 22h37 40
rodi01 commented 6 years ago

@giuseppebergman thanks again!

On the console window, could you run this command "window.data"? Like this: screen shot 2018-03-12 at 5 28 06 pm

Hopefully you will get something like this: screen shot 2018-03-12 at 5 28 13 pm

I wish I could reproduce it, I would probably be able to fix this a lot easier. Thanks for all your help.

giuseppebergman commented 6 years ago

Hey,

Sorry for being silent so long, I was way too busy these last days. I don't see "inspect element" anymore when I click on the blank window. I'll try with v3.7.3. and report here.

giuseppebergman commented 6 years ago

Okay, so there's no dropdown menu displaying anymore when right-clicking in the blank window, with Sketch 49.1 & plugin 3.7.3…

rodi01 commented 6 years ago

@giuseppebergman yeah, sketch changed to access the inspect element. Here is a thread on how to get that back: http://sketchplugins.com/d/665-sketch-49-webview-cannot-be-inspected-element-by-right-click Basically, you have to enable the flag in sketch with in the command line like this defaults write com.bohemiancoding.sketch3 WebKitDeveloperExtras -bool true

rodi01 commented 6 years ago

@giuseppebergman you will still need the dev version of the plugin. This one should still work https://www.dropbox.com/s/x8f9i4xo9kgqxds/Rename-It-find-rename.sketchplugin.zip?dl=0

giuseppebergman commented 6 years ago

Done and done! But I'm not sure "undefined" is very helpful :/ capture d ecran 2018-03-21 a 19h14 46

rodi01 commented 6 years ago

😪 Let me see what else I can do, I will keep trying. Thanks for the info.

giuseppebergman commented 6 years ago

You're welcome, thanks for trying!

Le 21 mars 2018 à 19h32, Rodrigo Soares notifications@github.com a écrit :

😪 Let me see what else I can do, I will keep trying. Thanks for the info.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rodi01/RenameIt/issues/68#issuecomment-375050600, or mute the thread https://github.com/notifications/unsubscribe-auth/ALbXvwCJITLmMLtvlMCgI8z-6-crfXY7ks5tgpzEgaJpZM4R0dQh.

giuseppebergman commented 6 years ago

Update: the Find&replace works in some files, and doesn't in others, with same versions of Sketch and plugin! How can I help you find why (sadly I can't share the mentioned files due to NDA clause)?

Giu_

rodi01 commented 6 years ago

@giuseppebergman That's interesting. Does it work on a brand new file with just a couple of rectangles?

JasonLang commented 6 years ago

HI! I'm seeing a similar issue for "Rename Selected Artboards".

When I select arboards and then run the plugin, I end up in a state with a blank screen. First, I type "10" then "%" and then "n". The window goes blank when entering "n". See the three screens attached.

screen shot 2018-03-29 at 11 09 56 am screen shot 2018-03-29 at 11 10 02 am screen shot 2018-03-29 at 11 10 06 am

Thanks!

rodi01 commented 6 years ago

@JasonLang huh! Sorry about that 😟 Does that happen to any file?

giuseppebergman commented 6 years ago

@giuseppebergman That's interesting. Does it work on a brand new file with just a couple of rectangles?

Yes, it works fine.

rodi01 commented 6 years ago

Just a heads up that I haven't forgotten about this issue, guys. It's been a very busy month at work and I haven't had time to look at this. In regards to the bug, any of you using any custom plugin that changes the default layer behavior?

rodi01 commented 6 years ago

Can you try this build? https://www.dropbox.com/s/6be123o9okzf4bw/Rename-It-skpm-update.zip?dl=0

I changed how the data loads.

nicolocampagna commented 6 years ago

Hi @rodi01 ,

i have exactly the same problem :(

screen shot 2018-06-21 at 13 14 20

I've even installed the version released in your last comment and nothing, doesn't work :( :( :(

HELP MEEEEeeee!!! Thanks :)

timparker commented 6 years ago

I have the same issue :'( this plugin looks like a godsend if this get's fixed 🙏🏻

timparker commented 6 years ago

I noticed when you're renaming instances of symbols in other documents, it work's fine - but renaming the actual symbols in the main symbols page loads the empty popup.

rodi01 commented 6 years ago

@timparker @nicolocampagna If you guys try with a new file with some symbols on it do the same happen?

Let me see if I can give you guys a different version that I'm currently working on.

rodi01 commented 6 years ago

@timparker @nicolocampagna can you guys try this version: https://www.dropbox.com/s/e902wq1njstwe60/Rename-It-webview.zip?dl=1

FIY: This won't work if your Mac OS version is El Captain or lower.

rodi01 commented 6 years ago

If you still have this problem, another user found out that if you clear the RenameIt history fixed his issue. Go to Plugins → Rename it → Settings

screen shot 2018-07-23 at 11 21 20 am

Click on "Clear History".

Hopefully this will fix for you too.