search

rodit / SnapMod

Xposed module for Snapchat.
195 stars 21 forks source link

[FR] Add option to spoof device as Pixel #202

Open Diniboy1123 opened 2 years ago

Diniboy1123 commented 2 years ago

Hi,

It is a known legend that Snapchat devs instead of handling camera apis directly use the system camera app and "screenshot" the output kinda. However there are a handful of devices baked into the source of the app that enable using the Camera2 API directly. Most of these are Pixels. Therefore I would like to request that you consider such an option.

I have already added this on a rom level as Pixel Experience already has a way to spoof devices. Adding snapchat there worked and drastically improved the quality of my images. Size of saved snaps also increased from less than 1 MB to 3 MB. https://github.com/PixelExperience/frameworks_base/blob/twelve/core/java/com/android/internal/util/custom/PixelPropsUtils.java#L47

There is also a similar project that uses LSPosed as well to do essentially the same thing but with Google Photos. Might be useful as a reference: https://github.com/BaltiApps/Pixelify-Google-Photos

It would be a nice addition, but if you decide to add it, maybe note that it might not work on devices that don't support the Camera2 API yet.

jammyjay commented 2 years ago

This is not a bug but a enhancement request and as such belongs in discussions, not here.

Rodit has stated that he is currently busy with real life work and thus any further development on Snapmod will be slow, if at all. I think we as the collective community, need to give him time.

No one should be asking for further enhancements at this time, until such a time as Rodit has indicated he will be able to resume development. It's the LEAST any of us can do.

Diniboy1123 commented 2 years ago

Oh yeah, my bad. I am used to most projects accepting issues for new feature requests and didn't check out Discussions in time. Afaik Rodit can move this thread there, so please do so if it's a problem.

I can also understand that he is busy, but I will keep the issue open, maybe it will be done in the future sometime. :relaxed:

Magna-Graecia commented 2 years ago

Thumbs up to this. I would greatly welcome this option.

jkooper32 commented 2 years ago

Didn't know that pixel devices used camera api2 as I use a pixel 5 as a daily driver. Haven't noticed that much improvement when taking Snapchat pics with my pixel vs my Samsung device but I'll have to look into this