rodizio1 / EZ-WifiBroadcast

Affordable Digital HD Video Transmission made easy!
GNU General Public License v2.0
817 stars 200 forks source link

1.6 supports 4 wifi chips ony #103

Closed gba-gbob closed 6 years ago

gba-gbob commented 6 years ago

As per below code if card does not fall under names stated it does not get put into monitor mode and fails to transmit receive packets. Would expect either error or sensible defaults for other devices.

https://github.com/bortek/EZ-WifiBroadcast/blob/master/wifibroadcast-scripts/profile#L230 https://github.com/bortek/EZ-WifiBroadcast/blob/master/wifibroadcast-scripts/profile#L307

rodizio1 commented 6 years ago

The wiki clearly states which chipsets and cards work. Defaults for other devices are not really possible as there are just too many variables and chances of it not working (just succeeding in putting the card in monitor mode doesn't mean it will work correctly).

An error-message in case of unsupported card would make sense though, I'll add that.

gba-gbob commented 6 years ago

Hi Rodizio1, I have MediaTek MT7601 which does not get initiated but is in the wiki. I also can confirm that it works. Thanks for quick response

gba-gbob commented 6 years ago

In addition it would be great to have ability to provide card config files based on driver name / usb id ? in this case new card can be added by users on the fly just by creating new file, and source it from the main script.

rodizio1 commented 6 years ago

Well, the MT7601 is a stupid story, people just used it and reported back it works. I wasn't aware that it was using the mt7601u driver, it has a Ralink USB ID, so I thought it also used the rt2800usb driver (Don't have one for testing ...).

The mt7601 missing from the if clause is a bug, sorry (I though the mt7601 was working again after re-adding the driver because nobody reported it doesn't so far).

I have added the module to the if clause in .profile like this now: if [ "$DRIVER" == "rt2800usb" ] || [ "$DRIVER" == "mt7601u" ] || [ "$DRIVER" == "rtl8192cu" ] || [ "$DRIVER" == "8812au" ]; then

Plus a check that tells the user if it's an unsupported or experimental card:

if [ "$DRIVER" != "rt2800usb" ] || [ "$DRIVER" != "mt7601u" ] || [ "$DRIVER" != "ath9k_htc" ]
    tmessage "WARNING: Unsupported or experimental wifi card"
fi

Regarding the card config files: I don't want to make changes that could possibly break things again now, but I'll keep that idea in mind.

rodizio1 commented 6 years ago

1.6RC6 has just been released, would be nice if you could report back if the mt7601 is working now.

gba-gbob commented 6 years ago

Can confirm works fine, I cannot see changes being published in master

rodizio1 commented 6 years ago

Thanks for confirming. Sourcecode on Github will follow (sorry, I'm always behind with that). Sourcecode in the image is there.