search

rodizio1 / EZ-WifiBroadcast

Affordable Digital HD Video Transmission made easy!
GNU General Public License v2.0
816 stars 200 forks source link

Welcome new contributors #155

Closed bortek closed 5 years ago

bortek commented 5 years ago

(This message is addressed to people who are in the list of Assignee, not to everyone else)

Hi guys!

EZwfb project that I am hosting code of on Github is in need of new enthusiasts who love the project and are willing to contribute and continue developing it. Thank you "careyer" for bringin this topic up.

Since you guys have been active on the forum and in the Issues discussions on Git I though you might be one of those enthusiasts :) Therefore I have added you as contributors on Github project which means you can push/pull/merge etc the code. I am sure we all have skills that can benefit the project in a good way. If for some reason you do not wish to be a contributor you can withdraw yourself trough the settings page.

If you have not worked with Github before please read-up about it or watch YT videos on the ways of working with github. Those who have previously worked with it can hopefully help others to get on track. My suggestion for the structure is the following:

Master branch is locked from changes directly and is supposed to be updated via Pull Requests.

There is now the new branch called "develop" which is a default branch where active coding is ongoing. Every time someone makes code changes , it is commited and then pushed to develop branch. This can be done several times before creating PR. When you feel ready create a PR towards master branch, discuss the changes in the PR by commenting. Then someone else other than the PR creator have to approve it. Afterwards it can be merged to master.

Usually after one or several PR when we feel ready for a new version we create a release from the master in Github and add new tag to it. All this is to encourage discussion. Feel free to create Issues and discuss there. It is easy and fun to reffer to the code changes from the Issues. Github is state of the art collaboration tool for dev projects. Sounds complicated? :) Dispair not, it is actually easy when you have done it few times.

Feel free to contact me by commenting here or via bortek666 (at) gmail dot com if you have any questions, thoughts or suggestions.

Regards /Boris

careyer commented 5 years ago

Thank you Boris for the confidence in us. We will just do our best to serve the project well because we believe in it. Feels awesome to belong to the official enthusiast circle! :-)

Yes21 commented 5 years ago

Yes Thank you to welcome us into this enthusiasts circle ! I will contribute to update the wiki pages.

careyer commented 5 years ago

@Yes21 : Feel free to take a glimpse at my structure suggestion at: https://www.rcgroups.com/forums/showpost.php?p=40335211&postcount=6150. Since I am very experienced with WBC-RC I would volunteer to contribute to the "RC Control Setup" section ;-)

htcohio commented 5 years ago

Boris,

Love the project, it has unlimited potential. I'm grateful that you brought me on and I am looking forward to contributing in any way I can.

I would highly recommend inviting User1321. He does not engage on the group very much but we have been working together over the last few months to develop new enhancements and optimizations. And, as a matter of fact today he just received some much needed RPI Hardware he didn't have on hand until now so that should accelerate the progress he was already making.

Cheers,

Justin

ase has already

careyer commented 5 years ago

Just overhauled the Wiki section with a new Navigation menu. Just minor changes ;-)

Please be aware that the pages follow some naming convention for better maintainability. e.g. Software : Advanced : Page name ... try to stick with that convention please.

Now we can go ahead and skim through the pages and update and add information. For all entries shown in black color e.g. "Software Setups - Quickstart Guide" a new page needs to be added with the "New Page" Button on the top.

bortek commented 5 years ago

@careyer Looks good. We try to preserver as much relevant info as possible. @htcohio user1321 is already invited, he hasn't accepted it yet. You are still to accept your collaborator invitation. ;)

Should we keep the image and link to v1.0 ? We dont even have release notes for it and I am sure no one is using it. The others can we keep for historical reasons and to see progress.

careyer commented 5 years ago

@bortek : Thank you very much. Yes I have not removed any of the information at all yet. Just restructred things and put things together that belong together. Next step will be to review the information since it is outdated in parts and add additinal infos and topics.

I guess we should keep the link to v1.0 because of "historical" reasons! v1.0 started it all :-)

Someone should also take the effort and update the code in the repository to reflect the latest release candidate 1.6rc6. The code currently shown is as of 1.5 or even older. That scares off a lot of people who want to tinker with the code or contribute based on the most recent version. @bortek : Maybe you can take care of this part? I am not so experienced in the Code section yet.

htcohio commented 5 years ago

@Bortek,

Would you mind telling me how to accept the invitation? I'm not seeing a link or reference here?

On Fri, Oct 12, 2018, 1:16 AM Bortek notifications@github.com wrote:

@careyer https://github.com/careyer Looks good. We try to preserver as much relevant info as possible. @htcohio https://github.com/htcohio user1321 is already invited, he hasn't accepted it yet. You are still to accept your collaborator invitation. ;)

Should we keep the image and link to v1.0 ? We dont even have release notes for it and I am sure no one is using it. The others can we keep for historical reasons and to see progress.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bortek/EZ-WifiBroadcast/issues/155#issuecomment-429206784, or mute the thread https://github.com/notifications/unsubscribe-auth/AcSp0iD29qe9SvkuD5q0YT0QPmXl0Gnjks5ukCWZgaJpZM4XYNu2 .

bortek commented 5 years ago

sure, let's keep v1.0.

Main issue with the code is that we do not have a mechanism to build the image using the source. Normally you have some build platform which sucks in the code from som repo (Git) and build the image using some base image plus the git code.

I do not know how rodi did it. I am just guessing here but I think he made the changes inside the the running image via shell and then after many changes the image was released as vX.Y.

Now the latest code is inside the the and I am not sure where to start. It feel a lot of work to just go into the running image and extracting pieces of code and files. Any suggestions ?

careyer commented 5 years ago

@bortek: I see! ... Yes there is an easy way how to extract all the latest source files from the image. Do you happen to know the program WinSCP? You can easiliy copy files between Windows and the running Linux image. After all it is just a matter of drag-n-drop. :-) This would allow to update all the files in the code repository to at least reflect the latest version. I think this is a good start. Many people have asked for it already.

It might also be a good idea to explain why we use this rather strange "non build mechanism supported" process. It might also be a good idea to invite the user "RespawnDespair" - he forked the latest repo and has setup such an build process. See: https://github.com/RespawnDespair/wifibroadcast-image-builder

@htcohio : You should have received an invitation email from the GitHub repo. Check your mail inbox and spam folder maybe?

htcohio commented 5 years ago

@htcohio user1321 is already invited, he hasn't accepted it yet. You are still to accept your collaborator invitation. ;)

Ok, I got it. You should have received confirmation. I was able to accept through the email link. :)

htcohio commented 5 years ago

@htcohio : You should have received an invitation email from the GitHub repo. Check your mail inbox and spam folder maybe?

I found it, I originally clicked on the link on RCgroups, not the email.

I've been reading and quickly starting to learn how Github works, the terminology etc... I also see that I can directly edit page info for the Wiki and install guide now that I accepted the invite.

I am starting to see how Github is a great tool for keeping collaboration on a project organized; assuming the basic guide is followed properly.

***What do you guys think about possibly changing the project name? Specifically, something that incorporates "FPV or HD" into the title? i.e. OpenHD-Wifibroadcast, FPV-Wifibroadcast or something similar?

The UAV/FPV community is small by some measurements, my thinking is that the title could provide better insight to what the project is about? Thoughts?

Yes21 commented 5 years ago

It might also be a good idea to invite the user "RespawnDespair" - he forked the latest repo and has setup such an build process. See: https://github.com/RespawnDespair/wifibroadcast-image-builder

Yes it would be great if "RespawnDespair" could join us, and also "Lelik" ...

htcohio commented 5 years ago

+1 on Lelik because I have a verified image working with the rpi3b+ which makes the ground Wireless 5G hotspot connection easy as cake and works perfectly with 2.4 radios 😉

bortek commented 5 years ago

I can check with RespawnDespair

We re not changing the project name at the moment :) . The usage of EzWfb is much more wider than FPV and multirotors. This is a video link system that you can hook up to anything. People have send a sond to the stratosphere with EzWfb and some even wanted to hook it up with some Cubesat.

@careyer I am quit familiar with both Win and Linux tools ;) Any idea which directory from the image to copy ? We can't take the whole root dir as it will include all the lib and binaries, at least they are presnet on any linux system. Or do you mean there is a specific dir we should copy ?

matiaspl commented 5 years ago

@svpcom 's fork of the original wifibroacast got some well thought of changes in terms of encoded stream processing, maybe he would backport his changes to this repo too

careyer commented 5 years ago

@bortek : Great! Just wasn't sure if you knew WinSCP. Yes we should copy the whole /root and its subdirectories. All the magic happens there. also not forget the .profile which is the most significant file of all that is hidden inside /root

As for the naming of the project: I also think we should keep the name! It is very well established and bortek is absolutrely right with his arguments. However it would be awesome to create a logo or somthing. Does anybody know a graphics designer by any chance? I think a logo is a crucial thing for for professional external effectiveness.

RespawnDespair commented 5 years ago

@svpcom did a wonderful job in regards to the actual video transmission. I have a test planned whether or not bidirectional telemetry communication would work with his solution as well. Since this is a major component of EzWFB right now, we need to keep that working. If we can include an even more robust video tranmission based on @svpcom 's work all derivatives should also benefit (e.g. Dronebridge).

In regards to image creation sigh i had this working mostly, but instead of just using the exisiting source i split everything up in order to make it more maintainable. I could give it another stab, it's in my repository now, but i would like to put it here, since this is the official place. I will be very clear upfront this time. It DOES work and CAN generate useful images, but i need HELP. Collaboration is key here, that's why i'm happy with this step and it reinvigorated my spirits, but i'm no Linux pro and my testing/dev time is limited.

pilotnbr1 commented 5 years ago

@bortek the files will be quite spread out. The present code and dir in the github gives a starting point. Most will be under the wifibroadcast dir but some will be in the root shell such as the .profile and there are probably some bash scripts that are not even uploaded to github. It’s all pretty bastardized between what was Befis original radio tap stuff that you would make, rangarid osd, Rodizio’s start scripts and rc stuff, and a smattering of Arduino... I might be able to help organize the code depending on time demands.

Edit just saw careyer post regarding just grabbing the whole root. That would be the most comprehensive solution, but I think someone would have to add an explanation as to where all the working parts are so that a new dev doesn’t get lost in all the other raspian crap.

I too think the present name is good as it has been around for a few years and is present in at least three different forums and languages. Logo is a great idea- it will give it more credibility. People get scared off because ezwbc seems so hackish.

htcohio commented 5 years ago

Since this is early on in the process, I just wanted to mention that I've been following this project called SRT by Haivision (secure reliable transport). The technical side is way over my head but it is extremely active everyday and it appears to have some advantages that may be able to be adapted to this project at some point in the future.

I just wanted to bring it to your attention, has anyone else seen this?

https://github.com/Haivision/srt

RespawnDespair commented 5 years ago

I might be able to help organize the code depending on time demands.

In my repository i took a stab at organizing the code. I also rewrote some things and split the bash script. Unfortunately the bash script i made is broken. I tried to be smarter than i was in regards to loading the configuration script.

I'm not saying my implementation is the gold standard, but it should provide a starting point, and it works with my image generation...

careyer commented 5 years ago

My friends, I'm really glad to see that life is coming back to the project and we have the chance to bring together all the smart ideas and the marvelous work of skillful people for good! I am happy to have kicked this off. You guys are awesome!

htcohio commented 5 years ago

As for the naming of the project: I also think we should keep the name! It is very well established and bortek is absolutrely right with his arguments. However it would be awesome to create a logo or somthing. Does anybody know a graphics designer by any chance? I think a logo is a crucial thing for for professional external effectiveness.

@careyer my brother-in-law is a graphics designer. I can definitely get that taken care of this weekend most likely. You can probably put together a couple Renditions for us to take a look at. Did you have any ideas or examples of similar logos that you had in mind?

RespawnDespair commented 5 years ago

@careyer I feel the same, i have always believed in this project. It has the potential to surpass anything commercially available right now. Perhaps one day we will look back to this as 'the beginning'. If i have some spare time this weekend i will draw up a schematic in regards to the structure and branching of the repository for you all to approve. It should simplify building and maintaining the images.

pilotnbr1 commented 5 years ago

@respawndespair that would be a huge help!

@htcohio thats an interesting project, maybe a better way to handle fec as currently its pretty good but does cost a slight bit of latency.

I see alot of ideas here. I think theres alot of low hanging fruit in terms of documentation, putting the current code on here, and better marketing of ezwbc. In keeping with the github framework and preventing this thread from getting outrageous, perhaps actual enhancements to ezwbc would best be done by submitting a enhancement request and then they can individually be discussed in their own threads.

user1321 commented 5 years ago

@RespawnDespair

@svpcom did a wonderful job in regards to the actual video transmission. I have a test planned whether or not bidirectional telemetry communication would work with his solution as well. Since this is a major component of EzWFB right now, we need to keep that working. If we can include an even more robust video tranmission based on @svpcom 's work all derivatives should also benefit (e.g. Dronebridge).

Good Day\Night\Morning to all!

Believe me, it will work. Also that thing very useful to transfer IP camera (RTSP) and other common messages. You can see implementation here: https://www.youtube.com/watch?v=sevEihOZncQ&t=95s Bidirectional telemetry and IpCamera based at svpcom code.

careyer commented 5 years ago

@htcohio : No I have nothing in mind as for a logo. It should just depict some of the core components like "wireless", "HD", "Streaming" maybe. I just got the idea because the Dronebridge Project looks so much more professional just because of the logo alone. Just let your designer depicts some drafts maybe that we can agree upon here.

@RespawnDespair / @all : Once the schematic and new code structure has been agreed upon I would like to contribute a working prototype image that user dino.de and I have works on over the course of several month. It offers some major improvements mainly in regards to the RC portion:

Maybe we can port some of this good stuff (all tested and working) to the new build. BTW: dino.de would also be an extraordinary contributor. He donated all the RC stuff in the first place.

RespawnDespair commented 5 years ago

@user1321 YES! Having you on board will propel the project even further. I am amazed by the things you have realized. If we can get everything into the repository here that would be one of the biggest steps. I'll get to work on my proposal and then we can collaborate on merging everything!

matiaspl commented 5 years ago

@htcohio @pilotnbr1 regarding SRT - from what I know it's not easily adaptable because it needs bidirectional IP communication to work. wbc's FEC has it's own advantages since we use airwaves. One thing we could transplant from e.g. DVB to make the streaming perform in a more reliable way is the Viterbi algorithm. From occusync we could borrow intra-frame refresh with client-side startup NALUs injection for lower latency and error recovery.

Yes21 commented 5 years ago

@RespawnDespair I'm very happy that you join us. I did tested your building script, and was waiting a lot of it. You did an enormous job, and I've been frustrated that it came not to the end. I really think your script will be the best way to generate next releases of EZ-WBC. @ALL Congratulations for this revival :))

Yes21 commented 5 years ago

@careyer It would also be great to integrate rtl8812/14au drivers. Did you contact "Lelik" ? Its last image is working great with AWUS036AC/H and AWUS1900 (but there's a bug in bidirectional telemetry). It would be better if his image could be merged with legacy EZ-WBC ...

user1321 commented 5 years ago

Generating images with help of Image-Builder probably will be best option. IMHO. In case if we will have a lot of source codes.... Btw, do Image-Builder generate image that can work at RPi 3 B+?

As for RussianImage... I can see that he use Kernel 4.9.80-v7, but what kind of patches did he apply to it, some one know?

careyer commented 5 years ago

@Yes21 : No not yet... I do not speak russian at all. Maybe @user1321 can contact him? user1321 you are from Ukraine as far as I know, right? Do you happen to speak russian?

user1321 commented 5 years ago

Also, I want to share information about progress that was achieved working together with Htcohio

  1. Camera Switch that based at "ArduCAM Multi-Camera Adapter Board for Raspberry Pi" It can switch up to 4 RPi camera`s via RC joystick. ( At one moment of a time only one camera active) Link to device: http://www.arducam.com/multi-camera-adapter-module-raspberry-pi/

  2. Android application that allow to change most of wifibroadcast-1.txt and osdconfig.txt (only #define IMPERIAL true, #define COPTER) settings. Currently it work in next way: 2.1. Phone establish connection with ground RPi via USB or WIFI. 2.2. Ground RPi send to phone settings from wifibroadcast-1.txt file. 2.3. In case of settings change at phone: Phone send request to ground RPi to change something in wifibroadcast-1.txt Ground RPi forward request to Air RPi to change something in wifibroadcast-1.txt. Ground RPi and Air RPi replay to phone that settings was changed. I have to say, that at my local side it works normally, but at side of Htcohio it`s work not very stable. So, I have to find and fix problem...

  3. Live CD iso file that may be written to USB flash drive and plugged to laptop. That will start Ununtu with patched kernel that will allow using WN722N receive video from RPi air + receive\send MavLink messages.

At this moment I`ll trying to create image that will boot at RPi 3B+, As soon I will do that, I will try to add to it Android application support and camera switch and will share with you.

P.S. Hope you will be able to decrypt my interpretation of English language :))

careyer commented 5 years ago

@user1321 your english is fine! You do not need to worry! May I please ask you to reach out to Lelik (the russion guy who did the rtl8812/14au drivers addition? Thank you very much! Maybe he has a GitHub account also and can contribute?

htcohio commented 5 years ago

I reached out to Lelik, He should respond quickly, I've talked to him a couple times in the last few days. Username LELIK does not appear to be on GitHub so perhaps his username is different?

@User1321,

I'm telling you your English is absolutely flawless. I don't know why you think you're typed English is not good. If I didn't know you I would have just assumed your some guy living in the US or some other English-speaking country.

A few weeks ago I signed up for this Rcdesign.ru Forum after having trouble signing up and not getting verification emails for some reason. FYI if you sign up the verification emails went into my junk email box.

Also, the translator on this site seems to come up with some interesting language translations that are nowhere close to what you're trying to say.

Rcdesign forum http://forum.rcdesign.ru/f90/thread515083-22.html

Lelik's page http://forum.rcdesign.ru/member.php?u=16248

On Fri, Oct 12, 2018, 11:19 AM careyer notifications@github.com wrote:

@Yes21 https://github.com/Yes21 : No not yet... I do not speak russian at all. Maybe @user1321 https://github.com/user1321 can contact him? user1321 you are from Ukraine as far as I know, right? Do you happen to speak russian?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bortek/EZ-WifiBroadcast/issues/155#issuecomment-429362091, or mute the thread https://github.com/notifications/unsubscribe-auth/AcSp0vkLt4GyoeOZkMWWy8nmKGIU6Azgks5ukLLzgaJpZM4XYNu2 .

user1321 commented 5 years ago

Sure I can contact to him, but firstly I want to ask All you guys, what exactly should I ask? Personally I interested in what kind of patches did he apply to kernel. Maybe something more?

Add: And maybe question why he decide to use exactly 4.9.80-v7. Was it random or some reason.

htcohio commented 5 years ago

Just to clarify, the camera switch, synchronized settings and, bi-directional telemetry all work perfectly fine if you use separate UHF or RC.

Everything seems to freeze up after a minute or so if wfb RC is used.

On Fri, Oct 12, 2018, 11:48 AM user1321 notifications@github.com wrote:

Sure I can contact to him, but firstly I want to ask All you guys, what exactly should I ask? Personally I interested in what kind of patches did he apply to kernel. Maybe something more?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bortek/EZ-WifiBroadcast/issues/155#issuecomment-429371637, or mute the thread https://github.com/notifications/unsubscribe-auth/AcSp0hrXPiKIaYoWkkcPDtpV3aTtBz8_ks5ukLnGgaJpZM4XYNu2 .

careyer commented 5 years ago

@user1321 : yes please ask him what patches he applied to the kernel to make the rtl8812/14au drivers work and maybe if he has a GitHub Account (account name) if he wants to contribute to "the original thing"

@htcohio : Sounds like a buffer overflow problem of some kind. Reliability of RC / bidirectional telemetry is cruicial. If we have to decide beweteen rtl8812/14au drivers and telemetry / rc stability we should go for the later one. As far as I can tell the new MavLink v2 from dino.de works flawlessly and absolutely stable. Good news btw: Chief devs @ ArduPilot have finally taged my feature request for >8Ch Mavlink-RC https://github.com/ArduPilot/ardupilot/issues/9472 YeahhH!! btw: @bortek could you please also invite the user dino.de? He is a wizard when it comes to teh RC part of EZ-Wifiboradcast and recently implemented state of the art Mavlink support in a test build

Yes21 commented 5 years ago

Sure I can contact to him, but firstly I want to ask All you guys, what exactly should I ask? Personally I interested in what kind of patches did he apply to kernel. Maybe something more?

@user1321 It would be interesting to know :

Thanks a lot

Ps : I've looked one time at the russian forum, but google translation seemed me like chinese !!

bortek commented 5 years ago

Great discussion and great spirit! :)

@RespawnDespair Your help will be much appreciated. We need to to establish some sort of build boilerplate so we can build an image using Github source (and perhaps raspbian base image).

Don't have very much time right now but what I plan to start with is to get the code out of an image. Afterwards we can together decide which one we want to merge/update with the existing codebase. If someone else wants to do it please let me know so we don't do a double work :-/

I think we are almost done discussing in this issue. So let each of us open new issue when we want to discuss specific issues.

Also we should create roadmap of what features do we want to develop/include in the coming releases (say 1 year ahead). Features that other alike projects do not have ;) Just have it in the back of your mind for now.

careyer commented 5 years ago

@bortek : Thank you! I am happy to hear what you just said. I was worring that you might think: "OMG what the hell have I done letting them into my Git - They're turning everything to the left!" I .. and i guess I speak for the others as well - we are really some hardcore enthusiats. We are sorry for that :metal:

Thank you for trusting in us!

htcohio commented 5 years ago

@Bortek,

It sounds like all the new developers are trying to figure out exactly where everything stands to get our bearings together to determine what needs to be worked on and addressed. There are several variants floating around out there between all of us and an issue or enhancement request might already be fixed on a different version that is already verified. For example, I have several feature request but it sounds like Careyer is or already has completed work on it so there isn't much sense adding that at the moment.

Baby it would be helpful if I started to write up a "road map" similar to what Wolfgang typed up for dronebridge. Does everyone think that is a good idea? We can add to an edit it as needed.

careyer commented 5 years ago

Good point @htcohio - Thank you for pointing this out! Indeed I have a much advanced 1.6rc6 image at hand that is proven to work 100% flawlessly. It enhances the 1.6rc6 image by the groundbraking features mentioned here . Because this unofficial "realease" makes some major leaps forward (eg. Mavlink v2 support and Air GPIO control - both crucial for a future AIO system) - and btw solving all the current bi-directional telemetry issues - I would like to vote to take this as a start and integrate all the other stuff from there.

If we really want to build a All-in-One (AIO) system Mavlink v2 support is absolutely crucial for success. For anybody not aware of what can be done with this check out this: 31.2km record flight with WBC-RC (credits due to khomyakk)

After all we must agree upon a starting point (anker) from where to start working and integrating. I think the changes done by @user1321 can rather easily (sorry to anticipate this - I have no idea) be applied to this anker and @RespawnDespair provides the structure that will help to get this into a development workflow like it is supposed to be.

If anybody could tell me a destination that I can upload 1,2GB to I would be more than happy to share that anker with you. Everybody okay with that? Any objections?

bortek commented 5 years ago

It sounds like you have a good image to start with. Can you upload it to your Google drive and share a link?

Yes21 commented 5 years ago

If anybody could tell me a destination that I can upload 1,2GB to I would be more than happy to share that anker with you. Everybody okay with that? Any objections?

:+1: +1

Ps : I suggest this new "anker" could be named : 2.0 rc1 (?!)

careyer commented 5 years ago

@All: No Google Drive... Dropbox instead, sorry: https://www.dropbox.com/s/yzavlwsfrcbys57/EZ-Wifibroadcast-1.6RC6_FlirOneG2_v0.9_omxh264_MavLinkv2_GPIO.img?dl=0

Based on a vanilla 1.6rc6 this image integrates:

"FLIRone" in action:

Video: https://youtu.be/5aDpvRuO9cI (video was recorded with 1.6rc5)

"insta 360 Air" in action: (thanks to johnboiles)

Some notes:

To track the changes you might want to search for the keywords: "FLIR", "switches", "airswitches" in the .profile. Feel free to reach out to me with any questions.

user1321 commented 5 years ago

Guys, I want to ask your opinion... We all have some kind of ISO images... As for me, I got mine by doing modification to working system via SSH terminal and after changes was done I just clone SD card to iso file. But, that is not an option anymore as we agreed store our modifications at GitHub. If we also agreed to use ImageBuilder as base for future releases I see it in next way:

  1. Upload "own" code to GitTree.
  2. Apply patch to copy of original ImageBuilder to let ImageBuilder build correct image that will reflect changes that was uploaded at step "1".

Maybe We can talk about it? Or any other ideas how can we do it? I just breaking my head now how we will add code and not move farther and farther from each other in our modification.

bortek commented 5 years ago

Of course we should talk about it! We probably everybody has images that they made modification to. But lets agree to select one image as a base and that should the one which has the most number of changes. As far as I can tell it is @careyer image. That has to be stripped down and extracted as files @user1321 do you know what changes you made, like you have some files saved somewhere perhaps ? If not then we will have to strip it down too into files. I can do it but it will take some time. I have an idea to mount IMG file into linux box as a partition and then just copy the files over.

Afterwards these changes need to be merged manually. @user1321 Can you elaborate a little bit on what is "copy of original ImageBuilder" ?

user1321 commented 5 years ago

I have an idea to mount IMG file into linux box as a partition and then just copy the files over.

If mainly you use Windows OS, you may easily do it with "ImDisk Virtual Disk Driver" Link to Wiki: https://ru.wikipedia.org/wiki/ImDisk

Can you elaborate a little bit on what is "copy of original ImageBuilder" ?

Sure, I mean at gitHub there is file that related to "wifibroadcast-image-builder" Create by RespawnDespair: https://github.com/RespawnDespair/wifibroadcast-image-builder/blob/master/build_images.sh It contain a numbers of instructions that determinate what exactly will contain generated ISO image.

If execute image build with all original content it will not reflect changes that can be potentially uploaded to GitTree.

So, Idea is simple:

  1. Upload "own\future" source codes to GitTree.
  2. Create -> apply patch to build_images.sh
  3. Execute patched build_images.sh that will build ISO image that will contain changes from "point 1"

In that case we will have one "stable\start" point and we can create our own modifications based at that "stable" point.

In case if we will patch ISO image`s.... That can be a hell. Just imagine: I have a lot of files that adopted to your WFBC 1.6. And suddenly we decide that new image will be (just for example) image that provided by Careyer. What should I do to adopt it to it? - Very carefully take a look at every changes that was done with it and apply all patches to it.

It`s ok. But what if after several days or months we decide that I have some release candidate? Do we will copy all changes from Careyer image to mine?

Maybe its good reason to use build_images.sh? All that is just ideas... Maybe i am wrong with it. Thats why I want to discuss it with All you)

ADD: P.S. And that with only two images, what we will do with 3, 4?

ADD2. Sorry that I add comments so often, but I was thinking about one more thing. In case if we will work based at Image.. To apply patches from one release to other we have to documented each line that was changed or use any tool that can compare files line by line... That will not be very easy task...