rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
693 stars 209 forks source link

Consider allowing co-maintainers #135

Closed patcon closed 10 years ago

patcon commented 11 years ago

Seems like you might be swamped or busy with other important things @rodjek. Any chance you might consider allowing some others to step in and help out?

I've seen the pull request hack approach work very well on other projects, particularly those run by @fgrehm: https://github.com/fgrehm/vagrant-cachier/issues/10

ringods commented 10 years ago

:+1:

patcon commented 10 years ago

bump

cc: @carlossg @hawknewton @bobtfish @petems @davidmarquis @hawknewton @bltavares (random recent contribs)

petems commented 10 years ago

Yeah, I'd be down to be a maintainer :+1:

davidmarquis commented 10 years ago

In the meantime, I suggest the fork librarian-puppet-maestrodev. We had a few problems with librarian-puppet and switched over to maestrodev's build. Now our workflow (admittedly quite simple) is working flawlessly, no trouble since switching over.

ringods commented 10 years ago

Currently no solution for Vagrant + vagrant-librarian-puppet that depends on the main repo instead of the maestrodev fork.

On 7 November 2013 12:05, David Marquis notifications@github.com wrote:

In the meantime, I suggest the fork librarian-puppet-maestrodevhttps://github.com/maestrodev/librarian-puppet. We had a few problems with librarian-puppet and switched over to their build, now our workflow (admittedly quite simple) is working flawlessly, no trouble since switching over.

— Reply to this email directly or view it on GitHubhttps://github.com/rodjek/librarian-puppet/issues/135#issuecomment-27954145 .

davidmarquis commented 10 years ago

What's your use case? I've been using a Vagrant setup with Puppet and librarian-puppet (maestrodev) for a while...

ringods commented 10 years ago

I'm preparing a fool-proof setup for a complete dev team to have a local system setup via Vagrant. In this setup, I do not want my (dev) users to run librarian-puppet manually, so I use the vagrant-librarian-puppet plugin which triggers librarian-puppet at the correct time in the provisioning process. The vagrant-librarian-puppet plugin depends on the main librarian-puppet gem instead of the maestrodev fork.

patcon commented 10 years ago

@davidmarquis Thanks very much for the pointer to your fork, but I'm really hoping we can resolve this and get the main repo moving again. Forks never show up in search results, so building on your fork will guarantee that there will be perpetual confusion and fragmentation, as PR's and conversations will continue to happen here as people discover this first.

@rodjek any chance you'd consider transferring the repo to the @maestrodev org?

Also, if anyone else felt like getting a temperature check of support outside this thread, feel free to RT to your networks :) https://twitter.com/patconnolly/status/398300767892688898

@rodjek also, sorry in advance for being such a pain :(

carlossg commented 10 years ago

I chatted with @rodjek back at PuppetConf and offered to help with the project. At @maestrodev we are not interested in keeping a fork, would rather contribute back to a common place and get more people involved

petems commented 10 years ago

Agree with @carlossg, I don't think @rodjek needs to transfer the repo over or anything. But a few collabs probably couldn't do any harm? :smile:

patcon commented 10 years ago

@petems :+1:

ringods commented 10 years ago

We are still missing @rodjek himself in the discussion...

patcon commented 10 years ago

Yeah, I'm kind of at a loss for what to do here.

EDIT: Ah wait, IRC. I'll ping him.

petems commented 10 years ago

You don't have to give the man the bums rush, we should probably just wait for him to respond in his own time?

ringods commented 10 years ago

@petems rest assured, I don't like to do this but a number of people depend on issues getting fixed and pull requests get merged. If @rodjek has too much work (last activity in this repo from 21 days ago), adding one or two co-maintainers is not that much work and would relieve him from the librarian-puppet maintenance. Everyone happy! :+1:

patcon commented 10 years ago

@petems I get what you're saying man, but I've been pinging him gently on like every channel for a month, saying "hey, just drop in a comment or add someone you trust as collab and we'll get this moving". I don't hold it against the guy, but it's honestly kinda frustrating that he's flaked on such a widely-used project. I air this grievance from a place of utmost appreciation for all he's done :)

hawknewton commented 10 years ago

Our only real option is to fork the project with the hopes that when @rodjek gets back we can merge back in.

rodjek commented 10 years ago

Sorry for the delay in responding to this. Time zones means I get the emails for this issue super early in the morning (before I wake) then it slips my mind as the day goes on.

I've added @carlossg and @patcon as contributors on the project, enjoy!

patcon commented 10 years ago

I would kiss you if there wasn't all this internet between us

patcon commented 10 years ago

@carlossg, what's your status? Do you have bandwidth today to help clean up the queues? As for me, if not later tonight, then I should be good tomorrow night.

And obviously I won't merge anything without discussion and +1's :)

ringods commented 10 years ago

@rodjek thanks a lot, but to really conclude this issue: can you add @patcon and/or @carlossg as owner for this project on RubyGems.org so they can make releases too? :+1:

http://rubygems.org/gems/librarian-puppet

carlossg commented 10 years ago

I brought in the maestrodev branch which is up to date with the master here, so after a few rebases should be good to go. I can do that tomorrow. It will supersede a bunch of pull requests

ringods commented 10 years ago

@patcon @carlossg what's the plan to get all pending pull requests in and released? Still waiting on some progress regarding the dependency on the puppet gem, needed to process recursive dependencies via the modulefile of git retrieved modules.

patcon commented 10 years ago

Friday's are the days I get to work on the project that uses this, so I'm hoping to jump in then :) (hold me accountable to that)

EDIT: Issue queue grooming and review is always helpful too

petems commented 10 years ago

BTW @rodjek If there's still spots going for maintainers I'm be up for the challenge?

Currently working on integrating VCR into Aruba so we can mock calls to github to get 403 responses and increase test coverage of the gem as a whole :+1: