search

rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
692 stars 209 forks source link

Default Puppetfile contains examples with Invalid module names #229

Closed sedan07 closed 10 years ago

sedan07 commented 10 years ago

Using v1.1.1 on Ubuntu 12.04 (ruby 1.9.3p0)

To recreate:

mkdir /tmp/librarian-puppet
pushd /tmp/librarian-puppet
librarian-puppet init
vim Puppetfile

Uncomment out one of the example mod lines, such as, plus comment out "modulefile":

mod 'ntp',
   :git => 'git://github.com/puppetlabs/puppetlabs-ntp.git'

and run:

librarian-puppet install

and the output will be:

Invalid module name 'ntp', you should qualify it with 'ORGANIZATION/ntp' for resolution to work correctly

The error message is correct however shouldn't the default file created by librarian-puppet stick to the librarian-puppet spec and allow a new user to try it out quickly be simply using the default config provided?

To clean up:

popd && rm ~/test/
carlossg commented 10 years ago

Fixed