search

rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
693 stars 209 forks source link

Incorrect install directory is create if the organization name contains a dash #261

Closed curator closed 9 years ago

curator commented 9 years ago

Due to a bit of naivete here (https://github.com/rodjek/librarian-puppet/blob/master/lib/librarian/puppet/util.rb#L56), modules with dashes in the org name (say... pwnies-ci/pwnies) will end up being installed into incorrect directory (ci-pwnies) names, which causes the module to not be found in puppet.

carlossg commented 9 years ago

I think organizations shouldn't have dashes, but sounds fare, we can assume that modules don't have dashes as stated in the Puppet docs