search

rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
693 stars 209 forks source link

Moved the cache-check to below the super, as the SHA is not yet known #266

Open hkolk opened 9 years ago

hkolk commented 9 years ago

We had an issue at work where gzip failed because the file was already there. The cause for this issue was that the vendor_cached? was checking without the sha in the file.

By moving the cache-call below the super call, we will know the sha and therefor can do the correct check.

hkolk commented 9 years ago

Let me know by the way if I missed a test-case or something alike. The original patch is something I just hacked together locally with a lot of print statements :)

carlossg commented 9 years ago

could you add a test under features/ to reproduce and ensure it doesn't happen again?