search

rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
693 stars 209 forks source link

librarian-puppet clean #27

Open jedi4ever opened 12 years ago

jedi4ever commented 12 years ago

Wondering if it should take into account the LIBRARIAN_PUPPET_DESCTRUCTIVE setting and only delete modules that are managed by librarian-puppet.

I see the clean is an action from librarian you invoke. Doing the above would require to monkey patch the behavior. Or maybe a check first.

Thoughts?

aussielunix commented 11 years ago

@jedi4ever I would say this is a bug.
clean should not be deleting modules that are not being managed by librarian-puppet.

As much as I am not a fan of monkey patching we kind of have to at this stage.

leonmax commented 10 years ago

@jedi4ever +1

I have to move the unmanaged modules out of the modules folder before deleting and move it back once down.

carlossg commented 10 years ago

FWIW I'm using a ./private_modules folder and in the Puppetfile 

mod 'moduleA', :path => './private_modules/moduleA'
robbyt commented 10 years ago

It's possible to define multiple modules folders in the puppet.conf, so maybe you should have one module folder that is librarian managed, and one that is unmanned.