search

rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
691 stars 209 forks source link

Mark Tags as Releases #289

Open tedivm opened 9 years ago

tedivm commented 9 years ago

According to Github the last, and currently stable, release was v0.9.17. Since then you've stopped issuing new Github releases and are simply tagging thing.

This is obviously an extremely minor issue, but it would help people who are using the Github API or even just people who happen to browse over here.

carlossg commented 9 years ago

1.5.0 and 2.1.0 show up in https://github.com/rodjek/librarian-puppet/releases

tedivm commented 9 years ago

Gthub puts tags into the release section by default, but does not mark them as a current release unless you actually go in and turn them into a release.

If you go to the 0.9.2 release page you'll see a big green icon that says "latest release"- https://github.com/rodjek/librarian-puppet/releases/tag/v0.9.17

If you browse the release you'll see that v0.9.17 is marked as "latest"- https://github.com/rodjek/librarian-puppet/releases?after=v1.1.0

Finally, if you're using the github API to find out what the current release is you are getting v0.9.17 instead of 1.5 or 21.

njam commented 9 years ago

Github releases are overrated ;)

tedivm commented 9 years ago

Whatever. I just thought you guys could make it easier for people who are pulling info about the project from the github api. If you don't care about those people than that's your problem.

njam commented 9 years ago

If one only has tags, will those be returned by the Github releases API? Or does it only work if you have actual releases?

carlossg commented 9 years ago

I think I'm going to stick to tags, seems that marking releases involves going to each tag and doing it which is quite inconvenient

tedivm commented 9 years ago

If you don't mark them as releases then the release API will return blank, which is actually good if you're not actually using releases- it would tell people you're not using them and allow them to fall back with tags.

Github's API is rest based, so you can see the results just by plugging in URLs-

https://api.github.com/repos/rodjek/librarian-puppet/releases

If you guys aren't actually using releases then you should remove the releases you have created (which appear to just be v0.9.13 through v0.9.17).

tedivm commented 9 years ago

@carlossg, that's fine, but you should fix the releases you've already made (by removing them as releases but not as tags). We've already talked about this issue longer than it would take you to clean it up.