rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
694 stars 216 forks source link

Update loop when dependency is specified in Puppetfile and by module #306

Open NoodlesNZ opened 9 years ago

NoodlesNZ commented 9 years ago

I ran into an issue recently where I had puppetlabs-concat in my Puppetfile and it was being required by puppetlabs-haproxy. The HA Proxy module had a setting of:

{"name":"puppetlabs/concat","version_requirement":">= 1.1.0 < 2.0.0"}

My Puppetfile was set to:

mod 'puppetlabs-concat'

This threw librarian-puppet into an endless loop of trying to resolve the dependencies on puppetlabs-haproxy and install an updated version of puppetlabs-concat. For the time being I resolved this by locking my Puppetfile puppetlabs-concat to version 1.2.2, but librarian-puppet should report on these types of problems and/or crash out of an endless loop

carlossg commented 9 years ago

can you post more information? complete Puppetfile, verbose logs, versions?

working fine here with the latest version

Conflict between puppetlabs-concat (< 2.0.0, >= 1.1.0) <https://forgeapi.puppetlabs.com> and puppetlabs-concat/2.0.1 <https://forgeapi.puppetlabs.com>
      Could not resolve the dependencies.
bijanvakili commented 8 years ago

@carlossg I also ran into this issue with librarian-puppet v2.2.1:

My Puppetfile had the following amongst a lot of other modules that had no issues:

forge "https://forgeapi.puppetlabs.com"

mod 'puppetlabs/concat'
mod 'puppetlabs/haproxy'
mod 'puppetlabs/stdlib'

My workaround was to: 1) Pin the version of puppetlabs/concat to 1.2.4 in my Puppetfile 2) Erase my entire modules folder

I'll probably pin the version of stdlib too.

But overall, I agree with @NoodlesNZ , a better error should be reported by librarian-puppet.