search

rodjek / librarian-puppet

http://librarian-puppet.com
MIT License
694 stars 216 forks source link

2.2.1 is more than 2 times slower compared to 2.1.1 #324

Open i11 opened 8 years ago

i11 commented 8 years ago

We have quite a few dependencies for our profile module and at seem that upgrading librarian to 2.2.1 slowed down the process more than 2 times.

Here are the test runs I did to compare. .tmp, .librarian, spec/fixtures and Puppetfile.lock where removed prior execution. 2.2.1:

$ time bundle exec librarian-puppet install --path spec/fixtures/modules --no-use-v1-api

real    10m41.059s
user    0m53.423s
sys 0m13.372s

2.1.1:

$ time bundle exec librarian-puppet install --path spec/fixtures/modules --no-use-v1-api

real    3m45.981s
user    0m47.553s
sys 0m12.693s

It seems that https://github.com/rodjek/librarian-puppet/commit/88efacffccdc26768542d7598f9721de2bc892cd makes that difference.

carlossg commented 8 years ago

any suggestions on how to improve the performance? the code in 88efacf is needed