The current check looks for the modules endpoint, but users can create and maintain their own endpoints. The plugin should be renamed and check for a valid endpoint name AND a subsequent path of the correct format. Notes from #561:
puppet:///modules/modulename/file could be tested for with puppet:///modules/\w+/
puppet:///othermount/file and puppet:///othermount/path/file are both valid and would match ^puppet:///\w+/\w+
puppet:///modules/filename is not valid and could be tested for with puppet:///modules/\w+$
If that seems reasonable, I will open a new ticket to track that change and link to it in the OP.
From February Triage: This is not called out in the style guide and should be disabled and moved to a community plugin. It should be disabled in 3.0.0.
The current check looks for the
modules
endpoint, but users can create and maintain their own endpoints. The plugin should be renamed and check for a valid endpoint name AND a subsequent path of the correct format. Notes from #561:puppet:///modules/modulename/file
could be tested for withpuppet:///modules/\w+/
puppet:///othermount/file
andpuppet:///othermount/path/file
are both valid and would match^puppet:///\w+/\w+
puppet:///modules/filename
is not valid and could be tested for withpuppet:///modules/\w+$
If that seems reasonable, I will open a new ticket to track that change and link to it in the OP.