Revert "Support directories for the manifest setting"

rodjek / rspec-puppet

RSpec tests for your Puppet manifests

http://rspec-puppet.com

MIT License

362 stars 202 forks source link

Revert "Support directories for the manifest setting" #755

Closed npwalker closed 4 years ago

npwalker commented 5 years ago

Reverts rodjek/rspec-puppet#748

This is a breaking change. For our modules we currently place various .pp files in spec/fixtures/manifests. Many of those .pp files conflict with existing pre_condition statements we have so after this change when in all of our tests failed with duplicate declaration errors.

coveralls commented 5 years ago

Coverage increased (+0.2%) to 86.087% when pulling b0706a256ead394b89304363ba9070f4bec4b8af on npwalker:revert-748-master into 491b7c8d6fe2c7fea615ed81aa90d96044b88a1d on rodjek:master.

jpartlow commented 4 years ago

@npwalker this can be closed (I don't have permission); I've removed the duplicate class declaration from puppet_enterprise and unpinned rspec-puppet (https://github.com/puppetlabs/puppet-enterprise-modules/commit/fac9174e5e2af0db91749b0f5a477154d4b01e9a).