Implement RSpec::Puppet::Coverage.add_filter_regex

rodjek / rspec-puppet

RSpec tests for your Puppet manifests

http://rspec-puppet.com

MIT License

362 stars 202 forks source link

Implement RSpec::Puppet::Coverage.add_filter_regex #807

Closed scotje closed 4 years ago

scotje commented 4 years ago

Closes #158

coveralls commented 4 years ago

Coverage decreased (-0.01%) to 85.343% when pulling a37eb03136412870204e03400f611d18f9e7012d on scotje:coverage_regex_filters into 7f309ce9f310650aaba481772be43b4487f9c51f on rodjek:master.

scotje commented 4 years ago

Only CI failure is due to the old Ruby 1.8-compatible version of rspec not having the output matcher.

scotje commented 4 years ago

Damnit - ruby 1.8.7 is not supporting (?>!...) negative lookbehinds. how about we just drop support for that ruby version?

Yeah I'm not worried about Ruby 1.8.7 failures, and I'd be OK with updating the gemspec to require at least Ruby 2.1 for the 2.8.0 release.