rodjek / vim-puppet

Puppet niceties for your Vim setup
Apache License 2.0
502 stars 137 forks source link

Ftplugin fixups #113

Closed lelutin closed 5 years ago

lelutin commented 5 years ago

I've been working on some fixups for the ftplugin file.

most of them don't change much in the behaviour so I didn't think of any tests for them, except for the last commit which changes the behaviour of the formatting function (e.g. now requires textwidth to be set to a non-zero value in order to break up long lines).

some of the changes however remove some unknowns from (e.g. setting formatoptions) and to user config (e.g. cleaning up for ftplugin and indent teardown will avoid unwanted side-effects if users change the filetype of a buffer).

There's also some corrections to options that make the plugin better reflect current puppet behaviour (restricting comment styles to C-style and shell-style, and removing "-" from keywords)

This prepares the terrain for a bug fix for breaking up long lines on which I've been trying to work (but failed so far) and a new feature to get the "gf" and accompanying commands working -- I'll send another PR based on this one to try and get some help.