I've taken your PR #96 and re-merged it on top of the current master.
From what I can tell the syntax highlighting works great! It looks like it's less confused about some parenthes or curly braces.
The syntax highlighting seems to be using more and more diverse color coding, which is great (it did show me some weaknesses of my colorscheme, but once they were fixed I think the result was nice!).
There's only one detail that I'm wondering about:
puppetInterpolationDelimiter has no highlight category assigned. it makes it stand out in a weird way.. maybe we should assign it to the Variable highlight group? or maybe Delimiter would suit better?
I'm not sure yet if assigning this to the "match" might affect the things that it contains.
Other than that, I think we should go ahead and merge this in asap since it makes our syntax highlighting so much better!
Hi there @rodjek !
I've taken your PR #96 and re-merged it on top of the current master.
From what I can tell the syntax highlighting works great! It looks like it's less confused about some parenthes or curly braces.
The syntax highlighting seems to be using more and more diverse color coding, which is great (it did show me some weaknesses of my colorscheme, but once they were fixed I think the result was nice!).
There's only one detail that I'm wondering about:
puppetInterpolationDelimiterhas no highlight category assigned. it makes it stand out in a weird way.. maybe we should assign it to the Variable highlight group? or maybe Delimiter would suit better? I'm not sure yet if assigning this to the "match" might affect the things that it contains.Other than that, I think we should go ahead and merge this in asap since it makes our syntax highlighting so much better!