search

rodjek / vim-puppet

Puppet niceties for your Vim setup
Apache License 2.0
502 stars 137 forks source link

add tag for class name with leading colons #123

Closed faxm0dem closed 3 years ago

faxm0dem commented 4 years ago

this makes the following work as expected:

include ::foo::bar::baz

Fixes #122

lelutin commented 4 years ago

hmm this potentially looks good. I'm trying to test before/after to make sure that I see that it's actually fixing things but I'm somewhat clueless as to how to use ctags with the file provided by the vim plugin.

how do you generate tags using this file? do you have to symlink your ~/.ctags to ~/.vim/bundle/vim-puppet/ctags/puppet.ctags or is it supposed to "just work" without any finagling?

currently before and after this patch is applied I get E426: tag not found: ::some::class when hitting ctrl-[ on the name of the class in a line like include ::some::class

lelutin commented 4 years ago

@Felixoid @davewongillies Since you worked previously on ctags support, you might have a better clue than I do on this subject. is this PR fixing the tag issue for classes that start with :: for you?

faxm0dem commented 4 years ago

I just copy the file to my ~/.ctags and the run ctags -R . in my project @lelutin did you re-run ctags -R . in your project?

Felixoid commented 4 years ago

I don't use Exuberant Ctags, but Universal Ctags, so that's my setup:

>±> readlink ~/.ctags.d/puppet_u.ctags
../tag-vim/vim/plugged/vim-puppet/ctags/puppet_u.ctags
lelutin commented 3 years ago

I will go ahead and merge this since I haven't gotten around to testing ctags yet. I'll trust that other folks who interacted with this issue may have said something too if there was a problem with the change.