Redirect to /dev/null caused segfault for nvim < 0.9.0

shadowwa commented 3 weeks ago

Tests are now covering case before/after milestone concerning epuppet:

epuppet detection added in filetype.vim in vim 8.2.2402
epuppet detection added in filetype.vim in neovim 0.5.0
filetype detection done with filetype.lua in neovim 0.8.0

lelutin commented 2 weeks ago

interesting. I will most definitely want to keep the removal of the redirection of stdout to /dev/null.

While I think adding older versions could help us identify what's going wrong with filetype detection, I wonder though: do we wish to commit/state that this module is going to keep its code compatible to such older versions of neovim?

we currently don't state clearly which versions of vim/neovim are supported in the README file.

seeing what I found about the versions distrubuted below, I'd be willing to support as far back as vim 9.0 and neovim 0.7.2. or if we push things, maybe vim 8.0 and nvim 0.7.0

what are your thoughts about this? am I being too optimistic about dropping support for older versions?

what's currently shipped in the most popular distros:

neovim:

in debian, stable has 0.7.2, unstable has 0.9.5 https://tracker.debian.org/pkg/neovim
in fedora, the oldest version is 0.8.0 in EPEL 8. latest release has 0.10.1 https://packages.fedoraproject.org/pkgs/neovim/neovim/
redhat apparently now asks for a login to do an rpm search. too bad that distro. but anyways it's based off of fedora
ubuntu's packages.ubuntu.com has been ill for a good while now so it's hard to tell what versions they even have
SUSE currently has .... I'm not sure if I understand how they work correctly, but if I understand correctly they currently ship 0.9.5 https://packagehub.suse.com/packages/neovim/
arch has 0.10.1 https://archlinux.org/packages/extra/x86_64/neovim/
freebsd has 0.10.1 https://www.freshports.org/editors/neovim/
netbsd has (not sure I'm interpreting correctly but..) 0.9.5 with maybe 0.10.0 incoming? https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/editors/neovim/index.html

so overall the oldest version among those is 0.7.2

vim:

debian stable has 0.9.0, unstable has 0.9.1 https://tracker.debian.org/pkg/vim
fedora seems to have 0.9.1 for all fedora releases https://packages.fedoraproject.org/pkgs/vim/vim-enhanced/
I .... can't find vim in suse packages? o_O
arch has 9.1 https://archlinux.org/packages/extra/x86_64/vim/
freebsd has 9.1 https://www.freshports.org/editors/vim/
netbsd has 9.1 https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/editors/vim/index.html

the oldest version among those is 0.9.0

lelutin commented 2 weeks ago

btw, this is side-tracking things a bit but @shadowwa you've been contributing a couple of changes for the last couple of years. I wonder if you'd like to become a part of this module's maintainer team?

I personally don't have the control over who has access to the repository, though. @rodjek what do you think about the above idea if they seem to be interested? I'm still interested in keeping this module alive but I sometimes go missing for months by lack of time / energy..

shadowwa commented 2 weeks ago

My first goal was to manage tests on any versions of vim/nvim we wanted, to continue to work on subtype detection. Now for the vim-puppet plugin, I think that if maintaining older vim compatibility is burden, a minimal version of vim 8.0 and nvim 0.7.0 is pretty good.

As for becoming part of maintainer, I'm willing to help but I'm afraid to be like you, as sometime lack time/energy.

rodjek / vim-puppet

Redirect to /dev/null caused segfault for nvim < 0.9.0 #155