structured variables in strings are not highlighted

rodjek / vim-puppet

Puppet niceties for your Vim setup

Apache License 2.0

500 stars 137 forks source link

structured variables in strings are not highlighted #98

Closed genebean closed 4 years ago

genebean commented 5 years ago

$facts['os']['family']
$foo = "Random bar ${unstructured} ${facts['kernel']}"

In the above example you can see that ${unstructured} is properly highlighted while ${facts['kernel']} is not. This happens with any kind of hash variable in a string (not just facts)

As a side note, I submitted a related issue for VS Code at https://github.com/lingua-pupuli/puppet-editor-syntax/issues/16

GerbenWelter commented 5 years ago

This seems to be already fixed by #75.

genebean commented 5 years ago

Based on the screenshot above I have to disagree @GerbenWelter. FWIW, the issue I linked in the original message has a fix posted to it now.

lelutin commented 4 years ago

@genebean I believe that the new syntax highlight (as it is on current master) has fixed this issue. the ${} itself gets no coloring, but variable names should be highlighted properly for both unstructured and structured variables.

please reopen if you are still seeing this problem.

genebean commented 4 years ago

Very nice! Thanks.