search

rodlie / qtfm

Qt File Manager
https://qtfm.eu
GNU General Public License v2.0
156 stars 43 forks source link

Improved version of Detail View #143

Closed ferion11 closed 5 years ago

ferion11 commented 5 years ago

For the https://github.com/rodlie/qtfm/issues/135 I'm using this on my notebook.

rodlie commented 5 years ago

Thanks, I will review the changes tomorrow.

rodlie commented 5 years ago

Sorry for the late reply. Looks ok, but files should not have the expand icon. qtfm-detailview-bug

ferion11 commented 5 years ago

On the View the files don't have expand icon. If you use the "QFileSystemModel", the expand icon show only for directory. But the "myModel" (from libfm) is saying that the file item can be expanded. I thought it was a feature, such as for previewing files or opening compressed files as if they were directories. I will review the "myModel" (from libfm) code.

rodlie commented 5 years ago

ahh, yes. Then we have a bug in mymodel.

rodlie commented 5 years ago

fixed in master.

rodlie commented 5 years ago

But that broke the tree dock... Will look into that later.

ferion11 commented 5 years ago

Probably because directories aren't the only ones having children. Some like this should solve: if (!parent.isValid()) return true; // for drives

rodlie commented 5 years ago

Seems to work, thanks.