Upgrade to julia 1.0.0?

[rodluger]

I installed julia 1.0.0 and had to change several things in the code to get things to compile. I'm doing this on a new branch v1.0.0 that I'll push soon. A couple things that currently break the code:

• Not placing spaces between a dot and an operator, such as in the expression 1.+2. This should be changed to 1. + 2 for it to compile correctly
• atan2 is now just atan
• tic and toc are deprecated (I think)
• lfact is deprecated

https://julialang.org/blog/2018/08/one-point-zero

[ericagol]

I saw a recommendation to first upgrade to v0.7, which is the same as v1.0, but still includes deprecation warnings. But, if that checks out, it makes sense to move to v1.0. The other upgrade remaining is to integrate over time; I haven’t carried this out yet.

[rodluger]

Ah, yes, 0.7 might be a good first step. I just got the code to compile on the v1.0.0 branch.

On Fri, Sep 28, 2018 at 12:15 PM Eric Agol notifications@github.com wrote:

I saw a recommendation to first upgrade to v0.7, which is the same as v1.0, but still includes deprecation warnings. But, if that checks out, it makes sense to move to v1.0. The other upgrade remaining is to integrate over time; I haven’t carried this out yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rodluger/limbdark/issues/36#issuecomment-425487774, or mute the thread https://github.com/notifications/unsubscribe-auth/AI5FKyTdWqX9grz_2e6wBCzKsAbzGRA1ks5ufksogaJpZM4W-wVd .

[rodluger]

@ericagol I'm working on the cleanup branch to go through all of your code / scripts / directories and organize it a bit better. I'm standardizing all plots and will soon standardize the test scripts. I am also slowly migrating things to version 0.7. Note that the paper is currently not compiling on master but I fixed the issue on cleanup and will create a PR in the near future.

[ericagol]

@rodluger Great, thanks! Do we still need to figure out why the v0.7.0 code was so much slower when you tested it?

[rodluger]

Yeah, I haven't figured that out yet.

[ericagol]

@rodluger Does the cleanup version have the changes that you made for compatibility with v0.7/1.0?

[ericagol]

@rodluger I don't see the v1.0.0 branch any longer - did you merge it with master?

[rodluger]

I deleted it because several of the changes I made broke the code. I started over in cleanup.

[ericagol]

@rodluger Seems like we may have resolved these issues in the cleanup branch?

[rodluger]

Yep!

[rodluger]

I'll set travis up to run v1.0 as well.

[rodluger]

Tests on travis are now running 0.7 and the latest build (currently 1.0.1).