Occasionally elliptic integral test doesn't pass

rodluger / Limbdark.jl

Analytical transit light curves for limb darkened stars

MIT License

14 stars 4 forks source link

Occasionally elliptic integral test doesn't pass #46

Closed ericagol closed 5 years ago

ericagol commented 6 years ago

[x] Look into the cases when test_cel_vec.jl doesn't pass, and fix the problem.

rodluger commented 6 years ago

@ericagol I added a randomizer seed to fix this issue. It is true that for certain random values of b and r the error exceeds the tolerance by a bit. We should try to explicitly find those values rather than running different numbers through the test each time.

ericagol commented 6 years ago

@rodluger Yes, that's what I meant. It doesn't seem to be affecting the precision of the computations as a whole, but we should track down and understand what is going on.

ericagol commented 5 years ago

It turns out that the numerical integration was at fault.