search

rodluger / Limbdark.jl

Analytical transit light curves for limb darkened stars
MIT License
14 stars 4 forks source link

Comparison to PyTransit #63

Closed rodluger closed 5 years ago

rodluger commented 5 years ago

Added curves for PyTransit to the figures where we are comparing to batman. Still working on a more general comparison to the Gimenez code, but you can see how much better we do in the figure showing the results for the N=15 nonlinear limb-darkening case.

Also started adding proofs to some of the equations.

ericagol commented 5 years ago

Is this the Gimenez' computation within PyTransit? It looks like starry is no longer being compared?

rodluger commented 5 years ago

@ericagol That's right. PyTransit uses Mandel & Agol to do quadratic (top plot) and Gimenez to do arbitrary order limb darkening (bottom plot). For the bottom plot, I'm computing the PyTransit flux in a similar way to how we're doing it with limbdark: i.e., I'm fitting for the 15th order coefficients of the limb darkening law that best approximate the nonlinear law's intensity.

image

rodluger commented 5 years ago

I removed the starry lines for now while I work on speeding up my code. I'll add them back in eventually.

rodluger commented 5 years ago

Also, the last purple point is missing in the bottom plot because PyTransit keeps segfaulting on Travis. I spent several hours trying to debug this and then just gave up!

ericagol commented 5 years ago

@rodluger Maybe you can compute one additional point - perhaps it just crashes on the last one?

rodluger commented 5 years ago

@ericagol Hmm, that's not the issue. My guess is the segfault is due to the code using 2-byte integers to index the arrays; these max out at about 33,000, so time arrays longer than that cause trouble. Let me see if I can force it to use larger integers.