rodluger / planetplanet

A general photodynamical code for exoplanet light curves
https://rodluger.github.io/planetplanet
GNU General Public License v3.0
45 stars 1 forks source link

Sign ambiguity #70

Open rodluger opened 6 years ago

rodluger commented 6 years ago

There's actually a sign ambiguity in the expression on this line! This leads to the incorrect points of intersection with the occultor in some cases. Should have led to bugs, but I think usually the intersections with the ellipses are sufficient to get very close to the right answer. This needs to be fixed, though.