search

rodluger / starry

Tools for mapping stars and planets.
https://starry.readthedocs.io
MIT License
144 stars 33 forks source link

nexsci extensions failing #233

Closed rodluger closed 4 years ago

rodluger commented 4 years ago

@christinahedges can you look into this? https://dev.azure.com/rodluger/starry/_build/results?buildId=868&view=ms.vss-test-web.build-test-results-tab

christinahedges commented 4 years ago

The extension is trying to query the exoplanet archive to download data. It might have been down this morning, I'm hearing other people having trouble too today. Is it possible to rerun the test? If it still fails, I'll remove that test.

rodluger commented 4 years ago

I just re-ran it, still failing. It's been doing this since last week at least. No need to remove the test. Is there someone we should contact about this?

On Mon, Mar 23, 2020 at 2:58 PM Christina Hedges notifications@github.com wrote:

The extension is trying to query the exoplanet archive to download data. It might have been down this morning, I'm hearing other people having trouble too today. Is it possible to rerun the test? If it still fails, I'll remove that test.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rodluger/starry/issues/233#issuecomment-602793721, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHEKK6L36S2UDGYE6Y6CXTRI6WNZANCNFSM4LR3TUYQ .

christinahedges commented 4 years ago

So when I run this test locally (cd in to the extensions/tests/greedy directory and run pytest test_greedy_nexsci.py) this runs for me and passes. Can you also try running it locally to double check? It could be something with the CI not being able to run the query to nexsci.

rodluger commented 4 years ago

Good point. It works for me locally as well. The issue is actually in a recent update to OpenSSL. Not sure how best to handle this, except to sit tight and wait for a fix in pyOpenSSL or urrlib. It looks like this is breaking lots of codes.

christinahedges commented 4 years ago

Ooh wow good find. I feel that these tests could totally be skipped for a few months if you didn't want to wait around, they are just checking to see if data can be requested from NExSci and if we can both run it locally it seems silly for this to hold up starry.

rodluger commented 4 years ago

This seems to be working now!