rodluger / starry

Tools for mapping stars and planets.
https://starry.readthedocs.io
MIT License
145 stars 33 forks source link

new `spot` function changes Y00 coefficient #277

Closed rodluger closed 3 years ago

rodluger commented 3 years ago

Describe the bug The new spot function changes the value of the Y_{0,0} coefficient. (Found by @fbartolic -- thanks!)

To Reproduce

map = starry.Map(20)
map.spot(contrast=-10, lon=190, lat=15)
print(map._y[0])

Expected behavior The Y_{0,0} coefficient should be fixed at unity; the normalization should be absorbed into map.amp.

rodluger commented 3 years ago

I implemented a fix on the dev branch: https://github.com/rodluger/starry/commit/525424489a20be8c29212b0f8058771e66879314