search

rodluger / starry

Tools for mapping stars and planets.
https://starry.readthedocs.io
MIT License
138 stars 32 forks source link

nexsci patch #282

Closed rodluger closed 3 years ago

rodluger commented 3 years ago

Nexsci CSV tables now have the following header:

***PLEASE READ*** This table is no longer updated and has been replaced by the Planetary Systems table (PS), which is connected to the Exoplanet Archive TAP service. Please review the TAP User Guide and create a new query for the most current data: https://exoplanetarchive.ipac.caltech.edu/docs/TAP/usingTAP.html. Please note the database column names have also changed; this document contains the current definitions and a mapping between the new and deprecated names: https://exoplanetarchive.ipac.caltech.edu/docs/API_PS_columns.html

which was breaking the pd.read_csv line. I am now skipping the first row, but we'll need a more permanent solution via the TAP service (see above).

This error was breaking starry on import, which is not good. Checks for new Nexsci data now happen only when the user explicitly calls the from_nexsci function for the first time.

rodluger commented 3 years ago

@christinahedges I'm going to merge this PR and publish a new version of starry on pip as soon as the tests pass, since this error will likely break everyone's installation within the week. When you get a chance, can you look into switching over to the new TAP csv tables (in a new PR perhaps)?

christinahedges commented 3 years ago

Yes 100%, sorry that my extension is breaking the import! I will look into the TAP query stuff, fully support a quick fix for now!