rodluger / starry

Tools for mapping stars and planets.

https://starry.readthedocs.io

MIT License

138 stars 32 forks source link

Fix `from_nexsci` method in `nexsci` extension #299

Closed christinahedges closed 2 years ago

christinahedges commented 2 years ago

297 shows that the `from_nexsci` method is failing. The method previously used pandas to download files from NExSci, but this is a bit janky and doesn't cache the files. This PR uses `astropy`'s caching feature to store the data in a `~/.starry` directory, which should be more robust.

christinahedges commented 2 years ago

I'm skipping the tests for the nexsci extension for Python 3.7.9 or lower. We find this error when we run the test: ssl.SSLError: [SSL: KRB5_S_TKT_NYV] unexpected eof while reading (_ssl.c:2570)

Which seems to be due to an issue with openssl. Because this isn't an issue with starry or astropy I don't see a clear way forward for us to fix it, and so this test is getting skipped. If users encounter this error, they may try updating their openssl version, which should fix this issue.

rodluger / starry

Fix `from_nexsci` method in `nexsci` extension #299

297 shows that the from_nexsci method is failing. The method previously used pandas to download files from NExSci, but this is a bit janky and doesn't cache the files. This PR uses astropy's caching feature to store the data in a ~/.starry directory, which should be more robust.

297 shows that the `from_nexsci` method is failing. The method previously used pandas to download files from NExSci, but this is a bit janky and doesn't cache the files. This PR uses `astropy`'s caching feature to store the data in a `~/.starry` directory, which should be more robust.