Viewport units fixed in iOS8

bratvanov commented 10 years ago

I can confirm that viewport units are finally fixed in iOS 8 that was just released.

Maybe we can update the UA test to exclude iOS 8 and only load the buggyfill in <iOS7, as from what I can tell at the moment "isMobileSafari" targets all versions which isn't optimal?

For a reference:

This is the UA on my iPhone 4S running iOS 7.0.3 which I purposely haven't yet updated to iOS8:

Mozilla/5.0 (iPhone; CPU iPhone OS 7_0_3 like Mac OS X) 
AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 
Mobile/11B511 Safari/9537.53

And here is the UA of my iPad Air running iOS 8.0:

Mozilla/5.0 (iPad; CPU OS 8_0 like Mac OS X) 
AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 
Mobile/12A365 Safari/600.1.4

rodneyrehm commented 10 years ago

You're welcome to send a PR ;)

bratvanov commented 10 years ago

Unfortunately writing efficient regular expressions isn't my strong suit, so I'd prefer if someone more knowledgeable was to help out. :)

ImBobby commented 9 years ago

Hello, any updates on this one?

rodneyrehm commented 9 years ago

Anyone is welcome to send a PR (Pull Request).

duranmla commented 9 years ago

I made a PR, hope it helps: https://github.com/rodneyrehm/viewport-units-buggyfill/pull/23/files

blowback commented 9 years ago

You're welcome to merge the PR, hint hint ;)

rodneyrehm commented 9 years ago

merged "manually", sorry… thx!

rodneyrehm / viewport-units-buggyfill

Viewport units fixed in iOS8 #19