Overpowered IE11 check breaks client-supported properties

rodneyrehm / viewport-units-buggyfill

Making viewport units (vh|vw|vmin|vmax) work properly in Mobile Safari.

MIT License

1.59k stars 151 forks source link

Overpowered IE11 check breaks client-supported properties #56

Closed radium-v closed 8 years ago

radium-v commented 9 years ago

Hi,

The check here causes issues when using units other than vmax. Rather than taking a sledgehammer/all-or-nothing approach, this check should be made later on to determine if vmax support is necessary, and should only apply fixes for vmax.

// added check for IE11, since it *still* doesn't understand vmax!!!
  if (!isBuggyIE) {
    isBuggyIE = !!navigator.userAgent.match(/Trident.*rv[ :]*11\./);
  }

rodneyrehm commented 9 years ago

how do you figure "check should be made later on" would work out?