Makes sure that the property of a style is not an url

rodneyrehm / viewport-units-buggyfill

Making viewport units (vh|vw|vmin|vmax) work properly in Mobile Safari.

MIT License

1.59k stars 151 forks source link

Makes sure that the property of a style is not an url #78

Closed jfabre closed 7 years ago

jfabre commented 7 years ago

Hello,

just had this issue that made me sweat for a while today. Please let me know if I need to do anything else to get this PR merged.

Commit msg

I actually got a bug with background-image property pointing to cloudfront with this url: https://d3r0d0kb2vhuxd.cloudfront.net

The viewportUnitExpression regex matched the url and the url got rewritten.

This is a fix to avoid that.

rodneyrehm commented 7 years ago

interesting. thanks for figuring this out!

if you could rename url to urlExpression (to fit with the others) and rename the commit message to fix(polyfill): do not consider URLs viable values for running the polyfill.

jfabre commented 7 years ago

ping! not sure why there's a conflict now.

rodneyrehm commented 7 years ago

the file was reindented. I resolved the conflict using the web editor (did not know this github feature existed...) thx!