search

rodneyrehm / viewport-units-buggyfill

Making viewport units (vh|vw|vmin|vmax) work properly in Mobile Safari.
MIT License
1.59k stars 151 forks source link

fixed viewportUnitExpression is matching base64 strings #86

Open OleksiiKukuruza opened 6 years ago

OleksiiKukuruza commented 6 years ago

@rodneyrehm check now please

rodneyrehm commented 6 years ago

better. But Line 294 uses viewportUnitExpression without the url test - meaning currently only values in KeyFrames are "safe".

The current solution will fail in situations like background: url(…) 2vw 2vh. Since url() can't be nested, we could probably test if a ) comes between url( and the identified value. If this is done, line 359 would need to be touched as well.