rodohanna / OpenCodenames

An implementation of the popular game Codenames created with Go and React.
28 stars 2 forks source link

Colour combination #3

Open officialgupta opened 4 years ago

officialgupta commented 4 years ago

For the red team spies, the red cards on the red background is not ideal

rodohanna commented 4 years ago

I agree that it's not the best. The one part I do like is that it obviously communicates which team you are on. Do you have any recommendations on how to keep which team each spy is on as obvious as possible and fix the red background issue?

officialgupta commented 4 years ago

I haven't formally considered it, but my initial thoughts were that the team background colour could be changed to a more subdued or different shade so the cards stand out. And / or the background could be patterned to distinguish it from the cards like this.

rodohanna commented 4 years ago

Thanks for the ideas! I couldn't find a satisfactory solution for now. I'd like to take some more time to experiment with the UI.

For now, I have added a 1px solid black border around each of the cards. I believe this is a good temporary fix to address the contrast issue.