Closed Habush closed 1 year ago
Hi @Habush, thanks I think this can be useful I'd just ask if you can add a couple of tests on the sklearn_genetic/test folder (in the two files in there), this is to make sure it doesn't break anything from the past and that the Github actions with automatic tests don't fail because of low tests coverage
Just as a side note, this will be removed as it's not neccesary to use the fit_params parameter, you can pass directly this to a pipeline object in case you're using it, or if you need a specify and fixed set of parameters for the estimator, this can be done when initializing the estimator
Hi,
First of all, thanks for this great library! While trying to use it, I noticed that the
fit
methods of bothGASearchCV
andGAFeatureSelectionCV
don't acceptfit_params
that may be needed by the estimator. I have updated the methods to accept this parameters so that users can pass parameters need for fitting the estimator.