Closed rodrigo-arenas closed 3 years ago
Merging #31 (d5802bf) into master (57989a6) will decrease coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 96.49% 96.42% -0.08%
==========================================
Files 18 18
Lines 571 559 -12
==========================================
- Hits 551 539 -12
Misses 20 20
Impacted Files | Coverage Δ | |
---|---|---|
sklearn_genetic/callbacks/early_stoppers.py | 100.00% <ø> (ø) |
|
sklearn_genetic/genetic_search.py | 99.38% <100.00%> (-0.04%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 57989a6...d5802bf. Read the comment docs.
This PR implements partially what is described in the issue #9, here is a summary:
What is done:
GASearchCV
now has inheritance fromBaseSearchCV
instead ofClassifierMixin
,RegressorMixin
.GASearchCV
documentation to see the full list. So the past hard-coded methods were removed.self.pop_size
toself.population_size
, this is to be consistent with the scikit-learnget_params
method; for this same reason, implemented some extra properties.What is left to do:
cv_results_
,best_index_
andmultimetric_
.