Closed rodrigo-arenas closed 3 years ago
Merging #54 (8012aa7) into master (86034f3) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #54 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 632 669 +37
=========================================
+ Hits 632 669 +37
Impacted Files | Coverage Δ | |
---|---|---|
sklearn_genetic/genetic_search.py | 100.00% <ø> (ø) |
|
sklearn_genetic/algorithms.py | 100.00% <100.00%> (ø) |
|
sklearn_genetic/callbacks/__init__.py | 100.00% <100.00%> (ø) |
|
sklearn_genetic/callbacks/base.py | 100.00% <100.00%> (ø) |
|
sklearn_genetic/callbacks/early_stoppers.py | 100.00% <100.00%> (ø) |
|
sklearn_genetic/callbacks/loggers.py | 100.00% <100.00%> (ø) |
|
sklearn_genetic/callbacks/validations.py | 100.00% <100.00%> (ø) |
|
sklearn_genetic/parameters.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 86034f3...8012aa7. Read the comment docs.
This PR implements what is described on issue #52, it adds the methods
on_start
andon_end
for the Callbacks. Now the evaluation process looks like this:As consequence of this new logic, the TimerStopping callbacks starts the timer using
on_start
instead of calculating this inside the GASearchCV itself.The Callbacks are not longer evaluated using the
__call__
method, but one ofon_start
,on_step
oron_end
according to the current state of the algorithm.All the docs and tests are updated to reflect this new logic.