rodrigo-arenas / Sklearn-genetic-opt

ML hyperparameters tuning and features selection, using evolutionary algorithms.
https://sklearn-genetic-opt.readthedocs.io
MIT License
289 stars 73 forks source link

understand_cv documentation spelling updates #57

Closed Turtle24 closed 3 years ago

Turtle24 commented 3 years ago

I updated the understand_cv documents grammar and spelling a bit. This is for #43 and I'll slowly go over all the documentation because I want to better understand the package and work on the inner workings eventually.

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (0163439) into master (123b1bd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          720       720           
=========================================
  Hits           720       720           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 123b1bd...0163439. Read the comment docs.

Turtle24 commented 3 years ago

Ey thanks! This is really useful, I see a lot of typos I missed and a better redaction.

I just have a comment on the change from "and search problems" to "and search of problems" in the line 25. I think it should remain the same.

What I want to tell, is that there is a subset of problems in optimization, that are called "search problems", see for example this page

Let me know what you think, and if you are agree, let's change that line before merging, thanks!

Ok awesome, I updated it. Yeah you're right, I missed the context so I get what you're saying 👍🏽

rodrigo-arenas commented 3 years ago

Great, this is looking good! Thanks again