rodrigo-arenas / pyworkforce

Standard tools for workforce management, queuing, scheduling, rostering and optimization problems.
https://pyworkforce.readthedocs.io
MIT License
75 stars 19 forks source link

Add numerical support #44

Open sfghuis opened 1 year ago

sfghuis commented 1 year ago

!Do not approve!

Sorry for the late response, I am changing jobs and had different priorities. I added support for pydantic, reduced multi-erlangC and erlangC to single ErlangC. Currently implemented test for the single scenario option and will expand on the mutli-scenario one later.

Aim of the mutli-scenario one is to allow for forecast uncertainties to be included as well, granting better insight into potential staffing requirements.

Could really use some feedback on how to improve the setup.

rodrigo-arenas commented 1 year ago

@sfghuis Thanks, so far it looks good, I'd just suggest changing the cErlangC_generic_variable_list to a dictionary, this way in the future, we won't rely on relative positions for each variable, but instead, we use their names Try to keep the PascalCase convention for class names and snake_case for functions/variable names

Also, make sure you pull the latest changes from the repo, I see you have a couple of conflicts

Let me know if you want me to check something else

sfghuis commented 1 year ago

@rodrigo-arenas I will work on making the list a dictionary. I hope to finalize the request today

sfghuis commented 1 year ago

@rodrigo-arenas Looking forward on your feedback. I added changes notes and updated the dependencies to be inline with your latest version.

Would it be ok if I added some error handeling for overflows values after finishing this request? In cases the transactions and intesities cause overflow errors?