search

rodrigo-brito / ninjabot

A fast trading bot platform for cryptocurrency in Go (Binance)
https://rodrigo-brito.github.io/ninjabot/
MIT License
1.39k stars 171 forks source link

model.Candle Complete might be improper for the Exchange other than Binance #221

Open nusicvvv opened 1 year ago

nusicvvv commented 1 year ago

I love ninjatrader for its simplicity. I need to make a bot using GateIO only to find, property Complete(bool) on model. It's impossible for me to determine which tick is the last tick for the ongoing (partial) candle, unless the tick to come next is for the next candle. I've never see a complete prop came along with tick data in other exchange than binance. this trait might limit ninjatrader's expansion in functionality.

Complete on Candle is what I can't get from GateIO history data or live feed. maybe I tried to make a something like CSVFeed to feed ninjatrader GateIO's history to backtest , but it seemed to i have to do more than that to even run the basic backtest emacross example.

rodrigo-brito commented 1 year ago

Hello @nusicvvv, the complete field is only used in a production environment, I believe it does not affect backtesting. Could you share your CSV input to analyze this case?