search

rodrigograca31 / Canvas2ImagePlugin

PhoneGap / Cordova plugin for iOS to save the contents of an HTML canvas to the device's Photo Library
19 stars 13 forks source link

Retrieve the image path also on iOS #11

Closed ataylor32 closed 4 years ago

rodrigograca31 commented 4 years ago

Thanks for the contribution but I noticed that ALAssetsLibrary is deprecated in iOS 9.0+.

Could you please change it to PHPhotoLibrary? (iOS 8+) This link should help

ataylor32 commented 4 years ago

@rodrigograca31 Yeah, I knew it was deprecated at the time that I made the pull request. I had actually already tried implementing PHPhotoLibrary myself, but I don't know iOS development, so I got lost pretty quickly when attempting. But I still think this pull request would be worth merging because it makes iOS behave the same as Android (currently they behave differently). I actually need this feature for a project I'm working on. It's a step in the right direction, and maybe somebody who knows iOS development can implement PHPhotoLibrary

rodrigograca31 commented 4 years ago

Ok, yeah you got a good point.

Can you just answer something? Its deprecated in iOS 9, but we are in iOS 13, it can still be used right? (because its deprecated but not removed)

ataylor32 commented 4 years ago

@rodrigograca31 I tried it on iOS 13.2.3 today and it worked.

rodrigograca31 commented 4 years ago

Thanks for the contribution @ataylor32 ! :heart: