Added iOS information to the README

rodrigograca31 / Canvas2ImagePlugin

PhoneGap / Cordova plugin for iOS to save the contents of an HTML canvas to the device's Photo Library

19 stars 13 forks source link

Added iOS information to the README #7

Closed ataylor32 closed 5 years ago

rodrigograca31 commented 5 years ago

Isn't this already done here?

https://github.com/rodrigograca31/Canvas2ImagePlugin/blob/7ee221b4fabae73ee8b714b377b39b0a64fb0229/plugin.xml#L38-L41

It seems almost the same variable.... Maybe both are needed.... Keep In mind I know almost 0 about iOS.

ataylor32 commented 5 years ago

I'm not sure if the one you linked to is required or not. I just know that it wasn't working for me until I added NSPhotoLibraryAddUsageDescription. I'm not familiar with plugin.xml. Maybe adding it there would be better.

rodrigograca31 commented 5 years ago

man I want to accept your PR but at same time dont want to have two places (config.xml and plugin.xml) ........

I dont know which is better and can't easily test. so I will accept it now and hopefully in future someone cleans this a bit....